Add flag to dump cc-side property trees for comparison with Blink generated trees |
||
Issue descriptionThis flag will be used to compare the cc-side property tries before and after --blink-gen-property-trees is enabled to flush out any differences between Blink generated trees and the existing ones used by cc today (created by cc's PropertyTreeBuilder).
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/089786a49457e7795ad0f8d325950ffdb5280792 commit 089786a49457e7795ad0f8d325950ffdb5280792 Author: David Bokan <bokan@chromium.org> Date: Fri Jun 22 02:46:14 2018 [BlinkGenPropertyTrees] Dump cc property trees to console To see logs start chrome/content_shell with: --vmodule=layer_tree_host=3 Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1b03c2f11e0a05fa7588c8e31837e12488fc7b15 Reviewed-on: https://chromium-review.googlesource.com/1107263 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569516} [modify] https://crrev.com/089786a49457e7795ad0f8d325950ffdb5280792/cc/trees/layer_tree_host.cc
,
Aug 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16c1e12e3bcbc17828b7c67dc3a4a12e25c1e776 commit 16c1e12e3bcbc17828b7c67dc3a4a12e25c1e776 Author: David Bokan <bokan@chromium.org> Date: Mon Aug 13 23:35:40 2018 [BlinkGenPropertyTrees] Print logging per-line This patch prints the property tree logging by printing each line separately. This prevents truncation of the logging output on Android, where: LOG << ...long multiline string... Will be truncated after some finite number of characters. For long outputs such as the property trees we hit this quite easily. Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e70a5e66d8248b2faa478738db94c980c28e3f7 Reviewed-on: https://chromium-review.googlesource.com/1173156 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#582744} [modify] https://crrev.com/16c1e12e3bcbc17828b7c67dc3a4a12e25c1e776/cc/trees/layer_tree_host.cc
,
Aug 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f7e25a70e62195733872e864ce7e212817b7536 commit 1f7e25a70e62195733872e864ce7e212817b7536 Author: Philip Rogers <pdr@chromium.org> Date: Thu Aug 16 18:37:29 2018 [BlinkGenPropertyTrees] Add simple layer list logging This patch adds layer list logging. To use, start content shell with: --vmodule=layer_tree_host=3 Sample output: layer id 11 element_id: (0) bounds: 800x600 opacity: 1 position: 0.000000,0.000000 draws_content: 1 scrollable: 0 contents_opaque: 1 transform_tree_index: 2 clip_tree_index: 1 effect_tree_index: 1 scroll_tree_index: 1 layer id 14 ... There is currently no logging for cc::Layer so a selection of important properties has been dumped. Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I938492167619c262976083291bd6db9b4a39fef5 Reviewed-on: https://chromium-review.googlesource.com/1175855 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#583755} [modify] https://crrev.com/1f7e25a70e62195733872e864ce7e212817b7536/cc/trees/layer_tree_host.cc
,
Aug 18
,
Sep 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/705f65456f9616912ba83610bcb44c70530baa4e commit 705f65456f9616912ba83610bcb44c70530baa4e Author: Philip Rogers <pdr@chromium.org> Date: Thu Sep 13 21:28:51 2018 Add more LayerTreeHost and LayerTreeHostImpl logging This patch has 4 changes: 1) Layer tree json now includes property tree indices. 2) Indentation has been fixed in LayerTreeHost::DoUpdateLayers so it's clear the logging is for both layer-tree and layer-list codepaths. 3) LayerTreeHost::FinishCommitOnImplThread now dumps property trees and layer list if --vmodule=layer_tree_host=3 is passed. 4) LayerTreeHostImpl::ActivateSyncTree now dumps property trees and layer list if --vmodule=layer_tree_host_impl=3 is passed. If you desire the ultimate logging experience, use: --vmodule=layer_tree_host*=3 Bug: 854200 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5ce6bf235eba1bc6dbcbcedf4781bf742d6004fa Reviewed-on: https://chromium-review.googlesource.com/1217842 Reviewed-by: enne <enne@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#591165} [modify] https://crrev.com/705f65456f9616912ba83610bcb44c70530baa4e/cc/layers/layer_impl.cc [modify] https://crrev.com/705f65456f9616912ba83610bcb44c70530baa4e/cc/trees/layer_tree_host.cc [modify] https://crrev.com/705f65456f9616912ba83610bcb44c70530baa4e/cc/trees/layer_tree_host_impl.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bokan@chromium.org
, Jun 19 2018