New issue
Advanced search Search tips

Issue 854198 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Animated SVG images do not work

Project Member Reported by pdr@chromium.org, Jun 19 2018 
Animated svg image tests are failing with blink gen property trees:
NEEDBUG paint/invalidation/svg/image-animation-with-zoom.html [ Failure ]
NEEDBUG svg/as-image/svg-image-with-css-animation.html [ Failure ]

These can be run with:
third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees paint/invalidation/svg/image-animation-with-zoom.html svg/as-image/svg-image-with-css-animation.html
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10752e4ff38d605681896e04196e2b5eca0cfef7

commit 10752e4ff38d605681896e04196e2b5eca0cfef7
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Jun 20 00:48:21 2018

[BlinkGenPropertyTrees] Run DocumentAnimations::UpdateAnimations for svg

This patch runs DocumentAnimations::UpdateAnimations for svg images,
matching the SPV2 codepath. The corresponding non-svg-image
UpdateAnimations call is behind a SPV2 || BGPT conditional in
local_frame_view.cc.

Bug:  854198 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If5132139cb7dcf0add0227c189f73809933a20c3
Reviewed-on: https://chromium-review.googlesource.com/1107098
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568669}
[modify] https://crrev.com/10752e4ff38d605681896e04196e2b5eca0cfef7/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/10752e4ff38d605681896e04196e2b5eca0cfef7/third_party/blink/renderer/core/svg/graphics/svg_image.cc

Comment 2 by pdr@chromium.org, Jun 20 2018

Status: Fixed (was: Available)
►

Sign in to add a comment