New issue
Advanced search Search tips

Issue 854196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Paint invalidation tests are failing

Project Member Reported by pdr@chromium.org, Jun 19 2018

Issue description

The following tests are failing due to different layer output:
NEEDBUG paint/invalidation/compositing/clipping-should-not-repaint-composited-descendants.html [ Failure ]
NEEDBUG paint/invalidation/compositing/overlap-test-with-filter.html [ Failure ]
NEEDBUG paint/invalidation/compositing/repaint-overflow-scrolled-squashed-content.html [ Failure ]
NEEDBUG paint/invalidation/compositing/should-not-repaint-composited-descendants-on-overflow-change.html [ Failure ]
NEEDBUG paint/invalidation/compositing/should-not-repaint-composited-descendants.html [ Failure ]
NEEDBUG paint/invalidation/scroll/overflow-scroll-composited-non-stacking-child.html [ Failure ]
NEEDBUG paint/invalidation/scroll/repaint-composited-child-in-scrolled-container.html [ Failure ]

These can be run with:
third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees paint/invalidation
 
Labels: -Pri-3 Pri-2
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998c499ee17fcbfdde3071f82aa300e5d04e17d9

commit 998c499ee17fcbfdde3071f82aa300e5d04e17d9
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Aug 16 17:05:12 2018

[PE|BGPT] Fix paint/invalidation/background/obscured-background-no-repaint.html

- Disable under-invalidation checking for the test.
  Animated svg sometimes fail under-invalidation checking because the
  forced paint by under-invalidation-checking may paint differently
  based on the current timer, while without under-invalidation-checking
  we still get image changed notification which will cause needed
  paint invalidation.  We have already disabled under-invalidation
  checking in similar cases. Not sure why the test succeeded without
  blink-gen-property-trees, but the test does run normally in
  content_shell with --enable-blink-gen-property-trees.

- Modify the test to test raster invalidations instead of
  object invalidations (which was removed in crrev.com/582462), and
  ensure that the reference image is invalidated after animation is
  advanced.

Bug:  854196 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I7d00d61d15cb6172e216793c14a0b29b9d56be1b
Reviewed-on: https://chromium-review.googlesource.com/1176435
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583701}
[modify] https://crrev.com/998c499ee17fcbfdde3071f82aa300e5d04e17d9/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/998c499ee17fcbfdde3071f82aa300e5d04e17d9/third_party/WebKit/LayoutTests/paint/invalidation/background/obscured-background-no-repaint.html

Cc: pdr@chromium.org wangxianzhu@chromium.org
 Issue 857322  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00451ea69cb0c8c6207c6332624b6450558b7a7a

commit 00451ea69cb0c8c6207c6332624b6450558b7a7a
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Thu Aug 16 21:01:47 2018

[BGPT] Rebaseline some paint/invalidation tests

The tests failed because of different graphics layer structures about
ChildContainmentLayer and AncestorClippingLayer which are intentionally
not created by BGPT, so rebaseline them.

Bug:  854196 
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I96223cc733ff0a1e792d4660e8e667a7d9e17460
Reviewed-on: https://chromium-review.googlesource.com/1178628
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583807}
[modify] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/compositing/clipping-should-not-repaint-composited-descendants-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/compositing/overlap-test-with-filter-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/compositing/repaint-overflow-scrolled-squashed-content-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/compositing/should-not-repaint-composited-descendants-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/compositing/should-not-repaint-composited-descendants-on-overflow-change-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/scroll/overflow-scroll-composited-non-stacking-child-expected.txt
[add] https://crrev.com/00451ea69cb0c8c6207c6332624b6450558b7a7a/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/paint/invalidation/scroll/repaint-composited-child-in-scrolled-container-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment