New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854195 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocked on:
issue 866647

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Image layers are not scaled correctly

Project Member Reported by pdr@chromium.org, Jun 19 2018

Issue description

The following tests fail with blink gen property trees:
NEEDBUG images/color-profile-layer.html [ Failure ]
NEEDBUG images/pixelated-composited.html [ Failure ]

third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees images/color-profile-layer.html images/pixelated-composited.html

It looks like we are failing to scale directly composited images.
 
Cc: trchen@chromium.org
 Issue 844429  has been merged into this issue.
I think the failure in compositing/culling/tile-occlusion-boundaries.html is actually due to this bug, so I have merged 844429.
compositing/masks/mask-with-removed-filters.html is failing due to this as well.
Blockedon: 866647
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b77692bfed57cce20380850fb3b28a492998ebef

commit b77692bfed57cce20380850fb3b28a492998ebef
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Fri Aug 10 07:20:41 2018

[Blink/BGPT] Add directly composited image support for BGPT

This CL adds code to PaintPropertyTreeBuilder to create transform node
for CSS object-fit. Currently only LayoutImage is supported.

BUG= 854195 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If9002cae344c4a27c2c45cd8a7d9b94dda236861
Reviewed-on: https://chromium-review.googlesource.com/1168471
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582083}
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/layout/layout_image.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/layout/layout_image.h
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/paint/fragment_data.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/core/paint/replaced_painter.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/platform/graphics/bitmap_image.cc
[modify] https://crrev.com/b77692bfed57cce20380850fb3b28a492998ebef/third_party/blink/renderer/platform/graphics/bitmap_image.h

Owner: trchen@chromium.org
Status: Fixed (was: Available)
I think this is fixed?

Sign in to add a comment