New issue
Advanced search Search tips

Issue 854190 link

Starred by 1 user
Status: WontFix
Owner:
vakh@chromium.org
Closed: Jun 2018
Cc:
ajha@chromium.org
nyerramilli@chromium.org
ligim...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression

Blocking:
issue 850321



Sign in to add a comment

CSD event is seen after downloading 'not_a_rar.rar' file in chrome://safe-browsing

Project Member Reported by jmukthavaram@chromium.org, Jun 19 2018 
Chrome Version: 69.0.3465.0
OS: Windows 10

Test setup:

1. Safebrowsing policy enabled by default for google machines(check in chrome://settings page)
2. Launched chrome with flag --enable-features=”InspectDownloadedRarFiles” 
3. Open chrome://safe-browsing in a tab and keep it open


What steps will reproduce the problem?
(1) Navigate to 'https://aawc.gitlab.io/safebrowsing/page/links/' in another tab 
(2) Scroll down and download 'not_a_rar.rar' & file should be downloaded successfully.
(3) Navigate to chrome://safe-browsing , scroll down & observed below entry

Download requests (ClientDownloadRequest) sent


{
   "archive_valid": false,
   "archived_binary": [  ],
   "download_type": 13,
   "file_basename": "not_a_rar.rar",
   "length": 18,
   "url": "https://aawc.gitlab.io/safebrowsing/s/not_a_rar.rar"
}


What is the expected result?
No entry should be seen in Download requests (ClientDownloadRequest) sent of chrome://safe-browsing

What happens instead?
Entry seen in Download requests (ClientDownloadRequest) sent of chrome://safe-browsing

Please find the attached screencast for reference.

Will check the same on other OS & update the bug soon.

Thanks..!
CSD even seen for Not a Rar file download.mp4
3.1 MB View Download

Comment 1 by vakh@chromium.org, Jun 19 2018

Status: WontFix (was: Assigned)
This is actually WAI.

The file not_a_rar.rar is named so because it is not a valid .rar file (it is just a text file renamed with .rar extension).
However, as far as Chrome is concerned, it has .rar extensions so it is a rar file. And because it is a .rar file, a download ping should be sent, which happens.

Perhaps the file should be named: txt_renamed_as_rar.rar

Comment 2 by vakh@chromium.org, Jun 19 2018

Blocking: 850321

Comment 3 by jmukthavaram@chromium.org, Jun 20 2018 

Thanks for the reply.
Vakh@,
Could you please change TC-4 as per C#1 & rename the file too in required docs to be more clear on the requirement & with out any confusion in future.

Comment 4 by vakh@chromium.org, Jun 20 2018 

I have updated the test plan. Thank you for pointing that out.
See: https://docs.google.com/document/d/1jLpr1NvbMoBeaeldsjdZ-1l5uS9gze5ZXghL4TlJ3Bg/edit#bookmark=id.qz1vd481o0fx
►

Sign in to add a comment