Bookmarks: Selected folder or bookmarks and Swipe icons disappear on scrolling the bookmarks |
|||
Issue descriptionApp Version: 69.0.3464.0 iOS Version: iOS 11.4 Device: iPhone,iPad Steps to reproduce: 1. Launch chrome. 2. Sign in to chrome which has bookmarks 3. Tap on Menu > Bookmarks > Mobile Bookmarks. 4. Tap on Select at the bottom. 5. Select few folders or webpages. 6. Scroll the bookmarks Observed results: Selected folder or bookmarks and Swipe icons disappear Expected results: Selected folder or bookmarks and Swipe icons should not disappear Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : NA New UI in M69 Bug reproducible on the current beta channel build : NA New UI in M69 Link to video/image: https://drive.google.com/file/d/1R35OmoW9py44B40VuJFJuIMbsWDnxciu/view?usp=sharing
,
Jun 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b7433742f4d0c176a54d9c2a5b8686c42bddaf6 commit 2b7433742f4d0c176a54d9c2a5b8686c42bddaf6 Author: sczs <sczs@chromium.org> Date: Sat Jun 23 22:38:33 2018 [ios] Fixes crash in Bookmarks scrolling while NewFolder is being edited - Checks the IndexPath instead of the Cell on canEditRow, the previous method was causing new cells not to be on edit Mode when the table did was on edit Mode. - Moves back the editingCell setup to cellForRowAtIndexPath (like legacy) since it was crashing on willDisplayCell. - Creates a test to check the previous case. Bug: 854185 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic4f7b27a6a48d48d26a68b9297a4b17e535a542f Reviewed-on: https://chromium-review.googlesource.com/1112675 Reviewed-by: edchin <edchin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#569894} [modify] https://crrev.com/2b7433742f4d0c176a54d9c2a5b8686c42bddaf6/ios/chrome/browser/ui/bookmarks/bookmark_home_view_controller.mm [modify] https://crrev.com/2b7433742f4d0c176a54d9c2a5b8686c42bddaf6/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
,
Jun 24 2018
,
Jun 26 2018
Issue verified Version: Chrome Canary 69.0.3473.0 Device: iPhone iOS: 11.4 Selected folder, bookmarks and swipe icons do not disappear https://drive.google.com/open?id=1dCl08_0E8YNP9MHHIujXeSzJJU9TXuHt |
|||
►
Sign in to add a comment |
|||
Comment 1 by rakurati@chromium.org
, Jun 22 2018