First time entering fullscreen, a banner is displayed over the content with the wrong instructions |
|||||||||
Issue descriptionChrome Version: Beta 68.0.3440.14 when you enter fullscreen for the first time, a banner is displayed at an odd location, overlapping the content (not centered). It says something like “To exit full screen pull down from the top with both fingers”. The expectation is to have no banner at all. This particular issue is that the banner appears. A separate issue is that the banner is in the wrong spot, which is tracked by a separate bug (issue 844084 - 2D UI is not aligned correctly in fullscreen).
,
Jun 22 2018
Assigned to Gordon to verify the fix on Canary. Please assign it back to me when it's ready to be merged back.
,
Jun 26 2018
I was not able to repro in Canary, so I think it is fixed. However, this bug was sporadic, so it would be nice for others to try to confirm also. Please merge back.
,
Jun 28 2018
,
Jun 28 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 28 2018
,
Jul 2
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3af062b36db227214ef0b5db06162461d8a6aa97 commit 3af062b36db227214ef0b5db06162461d8a6aa97 Author: Amirhossein Simjour <asimjour@chromium.org> Date: Tue Jul 03 14:21:55 2018 VR: remove fullscreen toast on standalones Bug: 854181 Change-Id: Id2418b88928fcd998e67bed8f011f2dcbb4cc8f5 Reviewed-on: https://chromium-review.googlesource.com/1106293 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#569036}(cherry picked from commit d2e9c37af31979c907e2a497eb72e1d89b0f34ab) Reviewed-on: https://chromium-review.googlesource.com/1124700 Reviewed-by: Amirhossein Simjour <asimjour@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#587} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/3af062b36db227214ef0b5db06162461d8a6aa97/chrome/android/java/src/org/chromium/chrome/browser/fullscreen/ChromeFullscreenManager.java
,
Jul 3
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Jun 20 2018