Shows incorrect entries in forward history pop up |
|||||||||
Issue descriptionApp Version: 69.0.3465.0 canary iOS Version: 10.3.3, 11.4, 11.4.1 beta 2 Devices: iPhone 7 Plus, iPhone 8 Plus, iPad Mini Prerequisite: Enable #slim-navigation-manager flag from chrome://flags Steps to reproduce: 1. Launch iOS Chrome 2. Navigate to plus.google.com or mobile.twitter.com 3. Create some navigation history (ex. Home>Discover>Communities>Profile>Notifications) 4. Edge swipe from left to right until it reaches ‘Home’ 5. Long Press on Forward arrow Observed results: Shows incorrect entries in the forward history pop up Note: This is just a UI issue. Edge swiping from right to left, navigates to correct page Long press on Back arrow displays correct entries in history pop up Expected results: Should display correct entries in forward history popup Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Safari/Firefox: Firefox: No, Safari: No Bug reproducible on the current stable build :M67, Yes Bug reproducible on the current beta channel build :M68, Yes Type-bug-regression? No Link to Image/Video https://drive.google.com/open?id=1KvRNud-nsUkUPUSinswRpfzn6xLZMSmr
,
Jun 20 2018
It looks like maybe the wrong NavigationItem is associated to the WKBackForwardListItem. I'm away from my desktop now. Will investigate later.
,
Sep 12
,
Sep 14
Note for self: test with Safari user agent.
,
Oct 23
,
Nov 2
,
Nov 2
,
Nov 19
,
Nov 24
,
Nov 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/594f66a8db0a96124dc39c54eb5dea590d1232a3 commit 594f66a8db0a96124dc39c54eb5dea590d1232a3 Author: Justin Cohen <justincohen@google.com> Date: Tue Nov 27 17:58:04 2018 [Nav Experiment] Correct navItem title usage. - Work around pushState changes that overwrite the navigation item title on pushState. The root cause of the bug is crbug.com/908173. - Correctly set navigation item titles on restore. Bug: 854174 , 872211 Change-Id: Ife407429d7f2723fc9dac6458bf81bdb1ae64ff8 Reviewed-on: https://chromium-review.googlesource.com/c/1349776 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Reviewed-by: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#611180} [modify] https://crrev.com/594f66a8db0a96124dc39c54eb5dea590d1232a3/ios/web/navigation/wk_based_navigation_manager_impl.mm [modify] https://crrev.com/594f66a8db0a96124dc39c54eb5dea590d1232a3/ios/web/navigation/wk_based_navigation_manager_impl_unittest.mm [modify] https://crrev.com/594f66a8db0a96124dc39c54eb5dea590d1232a3/ios/web/web_state/ui/crw_web_controller.mm [modify] https://crrev.com/594f66a8db0a96124dc39c54eb5dea590d1232a3/ios/web/web_state/web_state_unittest.mm
,
Nov 27
,
Dec 4
Verified in 73.0.3629.0 Canary in iPad Air(iOS 12.0.1) and iPhone 8plus(iOS 11.4.1) Followed the steps mentioned in comment#0. correct entries are shown in forward history popup, looks good. Link to video: https://drive.google.com/file/d/1faKe9VXoDxzxrebW2pcxd25YrXPgQCF9/view?usp=sharing |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sczs@chromium.org
, Jun 20 2018Status: Assigned (was: Untriaged)