Issue metadata
Sign in to add a comment
|
Regression : Notification is not getting auto-scrolled to 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options on pressing 'Tab' |
||||||||||||||||||||||
Issue descriptionChrome Version: 69.0.3463.0/10797.0.0 dev-channel Peppy,Blaze and Kip OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Save any Image -> Notification is seen with 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options (2)Click on Uber tray -> Along with Uber Tray , saved image notification is also seen -> now press 'Tab' button until focus is on 'Close' icon (3)Again press 'Tab' button and observe Notification did not scroll down to 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options and after another 'Tab' -> observe focus can be seen on 'Clear All' option (4)Press 'Shift + Tab' to bring back focus to 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options -> observe Notification will scroll up (Please refer Video) Expected: 'Tab' focus should be seen on 'Uber Tray' Actual: Instead 'Tab' focus is seen missing on 'Uber Tray' This is Regression Issue as same is working fine in 69.0.3457.0/10784.0.0 dev-channel Peppy @tetsui: please confirm the Issue
,
Aug 8
UnifiedSystemTray does not have this issue.
,
Sep 4
C#2>> Issue is still seen on latest M-70 70.0.3538.0/110301.0.0 i.e. a)On pressing 'Tab' button observe Notification did not scroll down to 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options(i.e. to show tab focus is on those options) and after another 'Tab' -> observe focus can be seen on 'Clear All' option b)On Pressing 'Shift + Tab' (to bring back focus to 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' options) observe Notification will not scroll up i.e. focus cannot be seen on 'SHOW IN FOLDER' and 'COPY TO CLIPBOARD' (Please refer Video) Reopening Issue for confirmation Thanks..!!
,
Oct 22
,
Oct 22
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2819b8659153560cf923bfb4b6d507e0660cd893 commit 2819b8659153560cf923bfb4b6d507e0660cd893 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Tue Oct 23 02:23:06 2018 NotificationViewMD: Use default scroll behavior. NotificationViewMD overrides ScrollRectToVisible in order to show the entire notification when scrolled by tab focus, but it's not necessary. * ScrollRectToVisible(GetLocalBounds()) is called at least once from NotificationViewMD::OnFocus() so the entire notification is shown at this point. * Overriding ScrollRectToVisible makes child buttons to not be scrolled properly when the notification is too tall. TEST=manual BUG= 854151 Change-Id: Ic890cc33b2f74e41caf7a9e1a3b98d850cb937b3 Reviewed-on: https://chromium-review.googlesource.com/c/1293062 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#601829} [modify] https://crrev.com/2819b8659153560cf923bfb4b6d507e0660cd893/ui/message_center/views/notification_view_md.cc [modify] https://crrev.com/2819b8659153560cf923bfb4b6d507e0660cd893/ui/message_center/views/notification_view_md.h
,
Oct 23
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Aug 8