Issue metadata
Sign in to add a comment
|
Regression: Brightness icon is clickable, grey focus is seen when clicking and nothing happens |
||||||||||||||||||||||
Issue descriptionChrome Version:69.0.3463.0/10797.0.0 dev-channel Peppy,Blaze,Kip OS:Chrome OS What steps will reproduce the problem? (1)Recover build>> Hit Brightness key and then click on brightness icon (Refer video) and observe Actual: Brightness icon is clickable, grey focus is seen when clicking and nothing happens Expected: Either it shouldn't be clickable or when clicking some change in Brightness should occur This is a Regression issue as same is working fine in 69.0.3457.0/10784.0.0 dev
,
Jun 20 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7 commit 2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7 Author: Tetsui Ohkubo <tetsui@chromium.org> Date: Wed Jun 20 07:09:31 2018 Make button beside brightness slider unclickable. The button on the right of the brightness sldier is no-op, so we should call SetEnabled(false). In order to do this, this CL changed disabled color of the buton icon. TEST=manual BUG= 854148 Change-Id: I1f0e98540a86696351135275be8946b7250cbc12 Reviewed-on: https://chromium-review.googlesource.com/1107423 Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#568752} [modify] https://crrev.com/2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7/ash/system/brightness/unified_brightness_view.cc [modify] https://crrev.com/2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7/ash/system/unified/top_shortcut_button.cc [modify] https://crrev.com/2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7/ash/system/unified/top_shortcut_button.h [modify] https://crrev.com/2e5de0eb59df632ed1f780eecf5f75cd9f2f41a7/ash/system/unified/unified_slider_view.cc
,
Jun 20 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tetsui@chromium.org
, Jun 20 2018Status: Assigned (was: Untriaged)