Findit has detected a flake at test TargetDomainCreateAndDeleteBrowserContextTest.RunAsyncTest. Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I6e391fadbbf47aa6427a16495bdca3c88d456b05 Regression range: None Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzY5ODIxL2hlYWRsZXNzX2Jyb3dzZXJ0ZXN0cy9WR0Z5WjJWMFJHOXRZV2x1UTNKbFlYUmxRVzVrUkdWc1pYUmxRbkp2ZDNObGNrTnZiblJsZUhSVVpYTjBMbEoxYmtGemVXNWpWR1Z6ZEE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM If this result was incorrect, apply the label Test-Findit-Wrong, mark the bug as Untriaged and the component Tools>Test>Findit>Flakiness.
Findit identified the culprit r568213 with confidence 70.0% in the config "chromium.win / Win7 Tests (dbg)(1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzY5ODIxL2hlYWRsZXNzX2Jyb3dzZXJ0ZXN0cy9WR0Z5WjJWMFJHOXRZV2x1UTNKbFlYUmxRVzVrUkdWc1pYUmxRbkp2ZDNObGNrTnZiblJsZUhSVVpYTjBMbEoxYmtGemVXNWpWR1Z6ZEE9PQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N). Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness
Issue 854142 has been merged into this issue.
Since FindIt agrees that this is likely the culprit, I'll go ahead and revert.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e6092a29f787a7243d3dff4d6626dc3f62404d7 commit 7e6092a29f787a7243d3dff4d6626dc3f62404d7 Author: Marc Treib <treib@chromium.org> Date: Tue Jun 19 13:00:31 2018 Revert "Headless: don't run unload hooks upon web contents close." This reverts commit 0d53513f26f09e7f8654a30452e2676addb01a30. Reason for revert: Flaky tests, see bug Bug: 854143 Original change's description: > Headless: don't run unload hooks upon web contents close. > > Change-Id: I6e391fadbbf47aa6427a16495bdca3c88d456b05 > Reviewed-on: https://chromium-review.googlesource.com/1105041 > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > Commit-Queue: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568213} TBR=dgozman@chromium.org,pfeldman@chromium.org,eseckler@chromium.org Change-Id: I252909f78e6d33b98819f6510f780997327a6901 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1106077 Reviewed-by: Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#568417} [modify] https://crrev.com/7e6092a29f787a7243d3dff4d6626dc3f62404d7/headless/lib/browser/headless_web_contents_impl.cc [modify] https://crrev.com/7e6092a29f787a7243d3dff4d6626dc3f62404d7/headless/lib/browser/headless_web_contents_impl.h
Issue 854188 has been merged into this issue.
Findit identified the culprit r568213 with confidence 77.5% in the config "chromium.win / Win7 Tests (dbg)(1)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyswELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ9Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjk4MjYvaGVhZGxlc3NfYnJvd3NlcnRlc3RzL1ZHRnlaMlYwUkc5dFlXbHVRM0psWVhSbFFXNWtSR1ZzWlhSbFVHRm5aVlJsYzNRdVVuVnVRWE41Ym1OVVpYTjAMCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20TargetDomainCreateAndDeletePageTest.RunAsyncTest&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyswELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ9Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjk4MjYvaGVhZGxlc3NfYnJvd3NlcnRlc3RzL1ZHRnlaMlYwUkc5dFlXbHVRM0psWVhSbFFXNWtSR1ZzWlhSbFVHRm5aVlJsYzNRdVVuVnVRWE41Ym1OVVpYTjAMCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Comment 1 by Findit
, Jun 19 2018