New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 854130 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
hobby only
Closed: Aug 31
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 845426
issue 861759



Sign in to add a comment

New form parser believes missing mark-up on instagram

Project Member Reported by vabr@chromium.org, Jun 19 2018

Issue description

Chrome Version       : 69.0.3466.0
URL: https://www.instagram.com/

The sign-up form on instagram.com has the (new) password field marked-up correctly as autocomplete="new-password", but the username is not marked up with an autocomplete attribute.

As a result, the new parser won't recognise any of the text fields as the username (while the old picked the one before the new-password field).

This has no bad consequences:
(1) Chrome still saves correctly from the sign-up form (guidance through non-empty values).
(2) Chrome won't autofill the sign-up form with the new parser (that's actually an improvement).

The sign-in form is parsed the same in both parsers.
 

Comment 1 by vabr@chromium.org, Jun 19 2018

I'm planning to mark this as WontFix, based on the list of consequences. I don't see any need to implement a mitigation for M69.

Dominic, Vadym, do you agree?

Comment 2 by vabr@chromium.org, Jun 19 2018

Status: WontFix (was: Started)
Marking as wontfix as indicated. Happy to re-open if you disagree.

Comment 3 by vabr@chromium.org, Jun 19 2018

Status: Assigned (was: WontFix)
Slight correction about saving:
Chrome still parses forms for saving using the old parser (NewPasswordFormParser::Save() is not implemented yet).

So the new parser would currently likely not find the username to be saved. This needs to be fixed for saving, but still won't affect how Chrome behaves in 69.

Comment 4 by vabr@chromium.org, Jun 19 2018

Another instance: https://www.linkedin.com/: password fields get hints, but usernames don't.

Comment 5 by battre@chromium.org, Jun 20 2018

What would happen to a
<form>
  <input type="text" name="username">
  <input type="password" name="password" autocomplete="new-password">
</form>
that is not handled by autofill votes, when the autocomplete attribute is a fake and the user tries to fill the username/password via manual fallback?

Comment 6 by vabr@chromium.org, Jun 22 2018

The manual fallback would work with the old parser, and also with the new parser after https://crrev.com/c/1108209.

(The piece breaking this for the new parser is the explicit condition in NewPasswordFormManager, which is removed in https://crrev.com/c/1108209. So it's not the parser which causes it but the new filling infrastructure.)

Comment 7 by vabr@chromium.org, Jun 26 2018

https://www.heraldsun.com.au/ contains a more impactful version of this bug:

The login form has username marked up as autocomplete="email" (and password as current-password). Correspondingly, the new parser does not find the username.

Because this is a login form, this actually results in filling issues: it is not possible to get filling suggestions in the username field (it is still possible to get them in the password field). This particular page has the login form in a cross-origin iframe, so it has been never autofilled, but otherwise this would also mean the difference between being autofilled and not.
Blocking: 861759
Status: Fixed (was: Assigned)
This has been fixed by r571937.

Sign in to add a comment