New issue
Advanced search Search tips

Issue 854091 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 313888



Sign in to add a comment

text-decoration:overline/underline flips side when xml:lang="ja"

Project Member Reported by maikato@google.com, Jun 19 2018

Issue description

Chrome Version       : 67.0.3396.87
OS Version: OS X 10.13.5
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:OK
    Firefox:FAIL

What steps will reproduce the problem?
1.open text-overline-ja.xhtml on Chrome browser

What is the expected result?
decoration line shows on the right of characters for the first line (overline).
decoration line shows on the left of characters for the second line (underline).

What happens instead of that?
decoration line shows on the left of characters for the first line (overline).
decoration line shows on the right of characters for the second line (underline).


Please provide any additional information below. Attach a screenshot if
possible.
If I remove xml:lang="ja", it shows the expected behavior.
If I open a simpler html (attached too), it shows the expected behavior.

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.87 Safari/537.36



 
test-overline-ja.xhtml
502 bytes View Download
test-overline.html
352 bytes View Download
Cc: kkaluri@chromium.org
Labels: OS-Linux OS-Windows
Status: Untriaged (was: Unconfirmed)
Able to reproduce this issue on Windows 10, Debian Rodete and Mac 10.13.15 with chrome stable #67.0.3396.87 Canary #69.0.3466.0 and also on earlier version M-60 #60.0.3073.0
This is a non-regression issue, hence marking it as a Untriaged


854091-M60.png
83.9 KB View Download

Comment 2 by kojii@chromium.org, Jun 21 2018

Components: Blink>Fonts
Labels: allpublic
Owner: kojii@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look.

Comment 3 by kojii@chromium.org, Jun 21 2018

Results on Windows; from left to right, Chrome, Firefox, and Edge
underline-position-854091-win.png
28.2 KB View Download

Comment 4 by kojii@chromium.org, Jun 21 2018

and Mac, from left to right, Chrome, Safari, and Firefox.
text-underline-position-854091-mac.png
92.4 KB View Download

Comment 5 by kojii@chromium.org, Jun 21 2018

The [example 3] of the spec "suggests informatively" that the [default UA stylesheet] applies this behavior. Firefox and Chrome follow this suggestion, Edge follow only for underline, and Safari doesn't.

[example 3]: https://drafts.csswg.org/css-text-decor-3/#example-f2d155ef
[default UA stylesheet]: https://drafts.csswg.org/css-text-decor-3/#default-stylesheet

Comment 6 by kojii@chromium.org, Jun 21 2018

Found a bug in WebKit:

The underline position for Japanese/Korean vertical text is wrong.
https://bugs.webkit.org/show_bug.cgi?id=48936

The following bug is related (but not required):
[css3-text] Implement support for vertical writing mode in -webkit-text-underline-position
https://bugs.webkit.org/show_bug.cgi?id=112615

I just checked "Google Chrome	67.0.3396.99 (Official Build) (64 ビット) (cohort: Stable)
変更履歴	a337fbf3c2ab8ebc6b64b0bfdce73a20e2e2252b-refs/branch-heads/3396@{#790}
OS	Windows
"
Seems no matter xml:lang="ja" or not text-decoration:overline for vertical writing mode is display at left side now instead of right side.
And even though I added "text-underline-position: under left" the decoration line still can not be displayed at right side.
Blockedon: 313888
The work is in progress.
"lang" should work today though. The work in  issue 313888  is to support 'text-underline-position'.
Project Member

Comment 11 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3275ba2e5dd642f12db3d69f44539b484dfce05e

commit 3275ba2e5dd642f12db3d69f44539b484dfce05e
Author: Zheng(Jeff) Xu <zxu@kobo.com>
Date: Wed Sep 12 17:35:02 2018

Implement text-underline-position

R=kojii@chromium.org

Bug:  854091 ,  313888 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I3e1b37ab4e27a91ce30a004d4faf8ab98152f9ed
Reviewed-on: https://chromium-review.googlesource.com/1187726
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590743}
[modify] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/AUTHORS
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-underline-position-horizontal-ref.html
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-underline-position-vertical-ja-ref.html
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/reference/text-decoration-underline-position-vertical-ref.html
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-underline-position-horizontal.html
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-underline-position-vertical-ja.html
[add] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/WebKit/LayoutTests/external/wpt/css/css-text-decor/text-decoration-underline-position-vertical.html
[modify] https://crrev.com/3275ba2e5dd642f12db3d69f44539b484dfce05e/third_party/blink/renderer/core/paint/text_painter_base.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93625519dcf0a11cb77e9cd58a74d602d2307f47

commit 93625519dcf0a11cb77e9cd58a74d602d2307f47
Author: Koji Ishii <kojii@chromium.org>
Date: Fri Sep 14 18:46:11 2018

Ship 'left' and 'right' values for 'text-underline-position'

This patch marks these new values as "stable" in
runtime_enabled_features.json5.

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/gXXMY1grZ-o/b0y3ENIaCQAJ

Bug:  313888 ,  854091 
Change-Id: I2cb4174e644d338163ad5162c7574aaee75d3abd
Reviewed-on: https://chromium-review.googlesource.com/1226485
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591412}
[modify] https://crrev.com/93625519dcf0a11cb77e9cd58a74d602d2307f47/third_party/WebKit/LayoutTests/virtual/stable/webexposed/nonstable-css-properties-expected.txt
[modify] https://crrev.com/93625519dcf0a11cb77e9cd58a74d602d2307f47/third_party/blink/renderer/platform/runtime_enabled_features.json5

Status: Fixed (was: Assigned)
Shipping in M71.

Sign in to add a comment