New issue
Advanced search Search tips

Issue 854084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Dec 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

[WPT] CSS-animations 'GlobalEventHandlers' doesn't pass IDL test

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Jun 19 2018

Issue description

WPT import https://crrev.com/c/1105615 introduced new failures in external/wpt/css:

List of new failures:
external/wpt/css/css-animations/idlharness.html new failing tests: https://crrev.com/c/1105615/4/third_party/WebKit/LayoutTests/external/wpt/css/css-animations/idlharness-expected.txt

This import contains upstream changes from 901c2f9f0e4fd894297def0eac89e61d325a5643 to 61df0b90ef19a3c52daf3feada24db3ba28346ff:
File API: Match Firefox on readAsDataURL default MIME type.: https://github.com/web-platform-tests/wpt/commit/61df0b90ef19a3c52daf3feada24db3ba28346ff
Update mediacapture-main IDL file (#9794): https://github.com/web-platform-tests/wpt/commit/2052baf288587cabc6efb425d05b042b2635aa42
Update the css-animations IDL file (#9768): https://github.com/web-platform-tests/wpt/commit/726bce76a10f3aa1ae6679a9ebeabdf89b0c8172 [affecting this directory]
Reland: Floats and out-of-flow objects may not be adjacent to anonymous blocks.: https://github.com/web-platform-tests/wpt/commit/28b5323e37274805b1d1416273e3a941c9c7e08e [affecting this directory]
Add WebUSB FeaturePolicy WPT for Workers: https://github.com/web-platform-tests/wpt/commit/79341a4595235e423787ead010d83c5f3d6e5f03
OffscreenCanvas Text rendering tests: https://github.com/web-platform-tests/wpt/commit/3f543086e31e64fdec1185e22be58c23d3bc0118
Ignore some new PNG files in ci_built_diff.sh (#11561): https://github.com/web-platform-tests/wpt/commit/9e5d47e3aea2b135ecc67b40ea898a4e764fa7af
[idlharness.js] Add main interface as dep for implements: https://github.com/web-platform-tests/wpt/commit/f9b53c84450f825d0b7dffb942d75db043fa3ae4

 

Comment 1 by e...@chromium.org, Jun 28 2018

Components: -Blink>CSS Blink>Animation Blink>Media
Components: -Blink>Media
[1/5] external/wpt/css/css-animations/idlharness.html passed          
[2/5] external/wpt/mediacapture-record/idlharness.html passed
[3/5] external/wpt/mediacapture-image/idlharness.html failed unexpectedly (text diff)
[4/5] external/wpt/mediacapture-fromelement/idlharness.html passed
[5/5] external/wpt/mediacapture-streams/MediaDevices-IDL-all.html passed

grep external/wpt/ third_party/WebKit/LayoutTests/TestExpectations | egrep "idlharness.html|MediaDevices-IDL-all.html"


crbug.com/655458  crbug.com/721814  external/wpt/mediacapture-image/idlharness.html [ Skip ]
crbug.com/626703 external/wpt/requestidlecallback/idlharness.html [ Timeout ]
crbug.com/856601 [ Linux ] external/wpt/FileAPI/idlharness.html [ Pass Timeout ]
crbug.com/856601 [ Linux ] external/wpt/mediacapture-record/idlharness.html [ Pass Timeout ]


so it looks to me like external/wpt/mediacapture-image/idlharness.html has been failing for a long time.


or is this referencing the fact that external/wpt/css/css-animations/idlharness-expected.txt has a FAIL line in it?

This bug was filed against external/wpt/css/css-animations/idlharness.html only.

And yes, it's referencing the fact that because of an upstream change [*], the test now has more FAIL lines than before. In this particular case, it didn't have any failures (so there was no -expected.txt), but now it has one.

https://github.com/web-platform-tests/wpt/commit/726bce76a10f3aa1ae6679a9ebeabdf89b0c8172 
Labels: Pri-3
Status: Available (was: Untriaged)
Summary: [WPT] CSS-animations 'GlobalEventHandlers' doesn't pass IDL test (was: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/1105615)
FAIL Partial interface GlobalEventHandlers: original interface defined assert_true: Original interface should be defined expected true got false
Labels: Hotlist-Interop
Status: Fixed (was: Available)
no longer fails, must have been fixed along the way.

Sign in to add a comment