New issue
Advanced search Search tips

Issue 854081 link

Starred by 1 user
Status: Fixed
Owner:
aee@chromium.org
Closed: Jun 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Blue highlight doesn't appear properly from bottom after hitting tab key.

Reported by vku...@etouch.net, Jun 19 2018 
Chrome Version: 69.0.3465.0 (Official Build) Revision afc58bd4f30a4cfcc0a11c73e3198f25ff133b1e-refs/branch-heads/3465@{#1}  (32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.12.6,10.13.1,10.13.6) & Linux (14.04 LTS)

What steps will reproduce the problem?
(1)Launch chrome open 2-3 webpages, navigate to chrome://bookmarks/
(2)Click on page and press ctrl+A to select all bookmark entry.
(3)Now press tab key and observe the blue focus highlight on first url

Actual: Blue highlight doesn't appear properly from bottom after hitting tab key(i.e after Step 2 & 3)

Expected: Blue highlight should be properly visible from bottom after hitting tab key.

This is a regression issue broken in 'M69' and below is the manual bisect info
Good Build: 69.0.3447.0(Revision:563479)
Bad Build:  69.0.3448.0(Revision:563958)
Actual_Bookmark.png
76.3 KB View Download
Expected_Bookmark.png
69.0 KB View Download

Comment 1 by vku...@etouch.net, Jun 19 2018

Labels: RegressedIn-69 FoundIn-69 Target-69 hasbisect
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)
Narrow bisect URL:
You are probably looking for a change made after 563746 (known good), but no later than 563777 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/6bf61e1fb162b839f4220b1806459cd2d9c77450..edb011f9c5419adf438c27747ff1e53e78ea7782?pretty=fuller&n=50

Suspecting: r563769 ?

@aee: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Comment 2 by vku...@etouch.net, Jun 19 2018

Labels: -OS-Mac
Correction:
Will soon update the behavior of Mac OS X once latest canary build #69.0.3465.0 will be available.

Comment 3 by aee@chromium.org, Jun 19 2018

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e96f62b93a5a0fee822c8a09716eb911328c9659

commit e96f62b93a5a0fee822c8a09716eb911328c9659
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Wed Jun 20 03:06:22 2018

Bookmarks: when focused, increase z-index so outline is not cutoff when other items are highlighted

Bug:  854081 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ib73d38ea25ca0ea70e3322b1e5066cd6a2b5ded9
Reviewed-on: https://chromium-review.googlesource.com/1106421
Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568708}
[modify] https://crrev.com/e96f62b93a5a0fee822c8a09716eb911328c9659/chrome/browser/resources/md_bookmarks/item.html

Comment 5 by aee@chromium.org, Jun 20 2018

Status: Fixed (was: Started)
►

Sign in to add a comment