New issue
Advanced search Search tips

Issue 854057 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug-Regression



Sign in to add a comment

‘Search or type URL’ text in omnibox is not aligned properly

Project Member Reported by subhashi...@chromium.org, Jun 19 2018

Issue description

App Version: 69.0.3464.0 canary
iOS Version: 10.3.3, 11.4, 11.4.1 beta 2, 12.0
Device: iPhone 7 Plus, iPhone 8 Plus, iPhone X,iPad Mini

Steps to reproduce:
1. Launch chrome
2. Open a New Incognito Tab(Menu>New Incognito Tab)
3. Navigate to any webpage ex. cnn.com
4. Tap on ‘Back’ arrow

Observed results:
At Step 2: ‘Search or type URL’ text is aligned to center
At Step 4: ‘Search or type URL’ text is aligned to right

Expected results:
‘Search or type URL’ text should be aligned properly.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on the current beta channel build : M68, No


Type-bug-regression? Yes

Link to video/image:
https://drive.google.com/open?id=1PIi5EB5Z_DFyRCssAPt3k0rm01zFeJ42


 

Comment 1 by sczs@chromium.org, Jun 20 2018

Owner: stkhapugin@chromium.org
Status: Assigned (was: Untriaged)
stk@ could you PTAL?
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ce3c5732ec1f65fc1321d234791b5232211d6c3

commit 8ce3c5732ec1f65fc1321d234791b5232211d6c3
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Jun 27 10:16:38 2018

[iOS] Fix broken constraints in location bar on NTP.

Currently the NTP steady location bar constraints can be broken because
the location image view is set to nil, making the intrinsic size of the
image view zero. Use a distinct set of constraints in this case.

Bug:  854057 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I67c21c9482e7def487308470e494539a24dfe9f1
Reviewed-on: https://chromium-review.googlesource.com/1115126
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570721}
[modify] https://crrev.com/8ce3c5732ec1f65fc1321d234791b5232211d6c3/ios/chrome/browser/ui/location_bar/location_bar_steady_view.h
[modify] https://crrev.com/8ce3c5732ec1f65fc1321d234791b5232211d6c3/ios/chrome/browser/ui/location_bar/location_bar_steady_view.mm
[modify] https://crrev.com/8ce3c5732ec1f65fc1321d234791b5232211d6c3/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified in 69.0.3480.0 Canary, iPhone X  iOS 11.4, iPad Air  iOS11.4
Looks good

Sign in to add a comment