New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 854051 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 28 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: execution contexts are never created for iframes that were blocked due to mixed content

Project Member Reported by lushnikov@chromium.org, Jun 19 2018 
Originally reported downstream in Puppeteer repo: https://github.com/GoogleChrome/puppeteer/issues/2709

Steps:
1. Go to https://www.bennish.net/mixed-content.html
2. Open devtools -> Console
3. Observe no iframe execution context in the console context selector
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea

commit 2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea
Author: Andrey Lushnikov <lushnikov@chromium.org>
Date: Tue Jun 19 04:20:54 2018

DevTools: force-create execution contexts for mixed content iframes

This patch starts creating execution contexts for iframes that didn't
commit initial successful loading. This is a common situation for
iframes which navigation was blocked due to mixed content.

R=dgozman
BUG= 854051 

Change-Id: Ia1c39af39c1c99f20e69abfae48579ac1bc09021
Reviewed-on: https://chromium-review.googlesource.com/1102154
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568341}
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/iframe-no-src-execution-contexts-expected.txt
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/iframe-no-src-execution-contexts.js
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/mixed-content-execution-contexts-1-expected.txt
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/mixed-content-execution-contexts-1.js
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/mixed-content-execution-contexts-2-expected.txt
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/mixed-content-execution-contexts-2.js
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/iframe-no-src.html
[add] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/mixed-content.html
[modify] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/blink/renderer/core/loader/frame_loader.cc
[modify] https://crrev.com/2371b2ac335f4ef6aa91b22aa9dd3d0d39664eea/third_party/blink/renderer/core/page/page.cc

Comment 2 by lushnikov@chromium.org, Jun 19 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment