New issue
Advanced search Search tips

Issue 854032 link

Starred by 1 user
Status: Fixed
Owner:
cduvall@chromium.org
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome
Pri: 1
Type: Bug
Proj-Servicification



Sign in to add a comment

"SessionCleanupCookieStoreTest.TestDeleteSessionCookies" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Jun 19 2018 
"SessionCleanupCookieStoreTest.TestDeleteSessionCookies" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQQsSBUZsYWtlIjZTZXNzaW9uQ2xlYW51cENvb2tpZVN0b3JlVGVzdC5UZXN0RGVsZXRlU2Vzc2lvbkNvb2tpZXMM.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by treib@chromium.org, Jun 19 2018

Labels: OS-Android OS-Chrome OS-Linux
Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=services_unittests&tests=SessionCleanupCookieStoreTest.TestDeleteSessionCookies
Looks like it's been flaking for at least a few days across a few platforms.

Example failure log:
[ RUN      ] SessionCleanupCookieStoreTest.TestDeleteSessionCookies
[WARNING:sqlite_persistent_cookie_store.cc(959)] CreationDate too recent
[WARNING:sqlite_persistent_cookie_store.cc(959)] CreationDate too recent
[WARNING:sqlite_persistent_cookie_store.cc(959)] CreationDate too recent
[WARNING:sqlite_persistent_cookie_store.cc(959)] CreationDate too recent
[WARNING:sqlite_persistent_cookie_store.cc(959)] CreationDate too recent
../../services/network/session_cleanup_cookie_store_unittest.cc:161: Failure
Expected equality of these values:
  2u
    Which is: 2
  cookies.size()
    Which is: 4
Stack trace:
../../services/network/session_cleanup_cookie_store_unittest.cc:163: Failure
Expected: ("nonpersistent.com") != (cookie->Domain()), actual: "nonpersistent.com" vs "nonpersistent.com"
Stack trace:
../../services/network/session_cleanup_cookie_store_unittest.cc:163: Failure
Expected: ("nonpersistent.com") != (cookie->Domain()), actual: "nonpersistent.com" vs "nonpersistent.com"
Stack trace:
[  FAILED  ] SessionCleanupCookieStoreTest.TestDeleteSessionCookies (127 ms)

Comment 2 by treib@chromium.org, Jun 19 2018

Components: Internals>Services>Network
Owner: cduvall@chromium.org
Status: Assigned (was: Untriaged)
Looks like this has been flaky since the test was introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1090035. I'll disable.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73ae115c4ff74b371a08a46c34850684c67b7998

commit 73ae115c4ff74b371a08a46c34850684c67b7998
Author: Marc Treib <treib@chromium.org>
Date: Tue Jun 19 09:21:32 2018

Disable flaky SessionCleanupCookieStoreTest.TestDeleteSessionCookies

TBR=cduvall@chromium.org

Bug:  854032 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0af88589cf1bce8715660d4b7e71c95a697085f8
Reviewed-on: https://chromium-review.googlesource.com/1105766
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568377}
[modify] https://crrev.com/73ae115c4ff74b371a08a46c34850684c67b7998/services/network/session_cleanup_cookie_store_unittest.cc

Comment 4 by treib@chromium.org, Jun 19 2018

Labels: -Sheriff-Chromium SessionCleanupCookieStoreTest.TestDeleteSessionCookies Test-Disabled

Comment 5 by dxie@chromium.org, Jun 19 2018

Labels: Proj-Servicification-Canary
Status: Started (was: Assigned)
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fa1f15db02a52036f98c8895b73e8286095a0d3

commit 9fa1f15db02a52036f98c8895b73e8286095a0d3
Author: Clark DuVall <cduvall@chromium.org>
Date: Wed Jun 20 02:41:35 2018

Fix flaky SessionCleanupCookieStoreTest.TestDeleteSessionCookies

This should ensure the delete tasks get run.

Bug:  854032 
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I73304bee8ee59e3e30ecb060cd3288c2630c8191
Reviewed-on: https://chromium-review.googlesource.com/1106479
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568701}
[modify] https://crrev.com/9fa1f15db02a52036f98c8895b73e8286095a0d3/services/network/session_cleanup_cookie_store_unittest.cc

Comment 7 by cduvall@chromium.org, Jun 21 2018

Status: Fixed (was: Started)
Looks like this is fixed, please reopen if it flakes again.
►

Sign in to add a comment