New issue
Advanced search Search tips

Issue 853993 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 20
Cc:
chrome-autofill@google.com
rogerm@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Autofill-UKM


Sign in to add a comment

Autofill.SuggestionFilled is recording CreditCard::RecordType and AutofillProfile::RecordType in same metric

Project Member Reported by nikunjb@chromium.org, Jun 19 2018 
We are recording RecordType for credit card and profile in the same UKM. So, it is hard to know the record type recorded belong to which enum type.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba2c538835623e289ce4338881f0c38a9fca01c9

commit ba2c538835623e289ce4338881f0c38a9fca01c9
Author: Nikunj Bhagat <nikunjb@chromium.org>
Date: Sat Jun 23 01:39:14 2018

Add IsForCreditCard to Suggestion filled to correctly distinguish Profile Records and Creditcard Records

Bug:  853993 
Change-Id: I17d0ab8057f8a36a130d3ed2f4bb7d70883db9ce
Reviewed-on: https://chromium-review.googlesource.com/1105494
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Nik Bhagat <nikunjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569872}
[modify] https://crrev.com/ba2c538835623e289ce4338881f0c38a9fca01c9/components/autofill/core/browser/autofill_metrics.cc
[modify] https://crrev.com/ba2c538835623e289ce4338881f0c38a9fca01c9/components/autofill/core/browser/autofill_metrics.h
[modify] https://crrev.com/ba2c538835623e289ce4338881f0c38a9fca01c9/components/autofill/core/browser/autofill_metrics_unittest.cc
[modify] https://crrev.com/ba2c538835623e289ce4338881f0c38a9fca01c9/tools/metrics/ukm/ukm.xml

Comment 2 by nikunjb@chromium.org, Sep 20

Status: Fixed (was: Untriaged)
►

Sign in to add a comment