UKMTestCase failing on iPad |
||||||||||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of justincohen@google.com ios_chrome_integration_egtests (iPhone X iOS 11.3) on iOS-11.3 failing on internal.bling.main/iphone11-device-x64 UKMTestCase/testSingleSyncSignout UKMTestCase/testHistoryDelete UKMTestCase/testMetricsConsent UKMTestCase/testSecondaryPassphrase UKMTestCase/testSingleDisableSync UKMTestCase/testIncognitoPlusRegular https://ci.chromium.org/buildbot/internal.bling.main/ipad10-simulator-x64/12820
,
Jun 19 2018
Still failing, can't figure it out. mahmadi@ can you take a look? I'm going to disable the tests on iPad for now.
,
Jun 19 2018
Flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=ios_chrome_integration_egtests&tests=UKMTestCase They've been very flaky for at least a few days.
,
Jun 19 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de403170ea9cabbe26afd1917c286b80b1b7d688 commit de403170ea9cabbe26afd1917c286b80b1b7d688 Author: Justin Cohen <justincohen@google.com> Date: Tue Jun 19 13:32:39 2018 [ios] Disable UKM tests. Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id441f479a233d0aa1cd6c2761da40819e0be2bc2 Reviewed-on: https://chromium-review.googlesource.com/1105998 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568427} [modify] https://crrev.com/de403170ea9cabbe26afd1917c286b80b1b7d688/ios/chrome/browser/metrics/ukm_egtest.mm
,
Jun 19 2018
Could this have been caused by https://chromium-review.googlesource.com/c/chromium/src/+/1095596? It caused UKM tests to fail on official bots and has been reverted. If so, given that CL is reverted, the tests should be re-enabled.
,
Jun 19 2018
asvitkine@ That revert landed Jun 13. Our tests are still failing today, the 19th.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a202f765df582048a2a928d151324290012a664 commit 0a202f765df582048a2a928d151324290012a664 Author: Justin Cohen <justincohen@google.com> Date: Tue Jun 19 15:52:22 2018 [ios] Disable UKM tests everywhere on iOS. Previous CL was iPad only, but these tests are failing all over. TBR=olivierrobin@chromium.org Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I777f2677202564eb26a8b2735f3df55a1dfff3d9 Reviewed-on: https://chromium-review.googlesource.com/1106220 Reviewed-by: Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568470} [modify] https://crrev.com/0a202f765df582048a2a928d151324290012a664/ios/chrome/browser/metrics/ukm_egtest.mm
,
Jun 19 2018
Should this bug actually block M68 Beta? M68 branched before this test started failing on trunk, right?
,
Jun 19 2018
My understanding is we want tests fixed ASAP. If I mark M69, wouldn't that mean a fix isn't needed until later? If there's something serious blocking it, we can always move the milestone?
,
Jun 19 2018
Presumably, this test is still running fine on the M68 branch, so moving this to M69. Also of note, this is the test failing in setup, not actually catching a privacy bug. Still needs to be fixed though.
,
Jul 18
Thanks for moving to M69, holte@. Justin, Mohamad, any update here for M69? First beta is scheduled for next Wednesday 7/25.
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/897fb66627d42c80aaad47fd5542bd9851cd8dd1 commit 897fb66627d42c80aaad47fd5542bd9851cd8dd1 Author: Moe Ahmadi <mahmadi@chromium.org> Date: Tue Jul 24 13:43:17 2018 [IOS][UKM] Fix and enable UKM EG tests on iOS UKM EG tests were failing on iOS because the signed in account was staying around after signing out causing EG selector to fail to tap on the appropriate account in subsequent sign in attempts. This CL fixes that by removing the signed in account when signing out. Bug: 853992 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I77ec271bbb694766b6487be52ec4e3a18f7839d4 Reviewed-on: https://chromium-review.googlesource.com/1146986 Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#577511} [modify] https://crrev.com/897fb66627d42c80aaad47fd5542bd9851cd8dd1/ios/chrome/browser/metrics/ukm_egtest.mm
,
Jul 24
,
Jul 24
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.
,
Jul 24
Requesting merge into M69 since this was a beta blocker and M69 is now beta.
,
Jul 24
In offline conversation, we will not merge this to M69. It is a flaky test issue, not a product issue. This is already landed for M70 and that is good. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by justincohen@chromium.org
, Jun 19 2018Status: Assigned (was: Available)