New issue
Advanced search Search tips

Issue 853968 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

generate_build_files failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jun 18 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c

commit 1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c
Author: Steven Holte <holte@chromium.org>
Date: Mon Jun 18 23:12:31 2018

Revert "Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2."

This reverts commit 08410d5699d3b709c775337c15e2c9e594c50aed.

Reason for revert: 
This appears to be causing build failures due to a DEPS issue:
https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8943347677136985328%2F%2B%2Fsteps%2Fgenerate_build_files%2F0%2Fstdout

BUG= 853968 

Original change's description:
> Fuchsia: Implement MixerOutputStreamFuchsia using AudioRenderer2.
> 
> Previously MixerOutputStreamFuchsia was using media_client library,
> which is deprecated now. Update it to use AudioRenderer2 FIDL interface
> directly.
> 
> Bug:  851733 
> Change-Id: I72a43369d16ecd626aa7294a6f3500b57bb3731e
> Reviewed-on: https://chromium-review.googlesource.com/1100376
> Reviewed-by: Kenneth MacKay <kmackay@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568159}

TBR=wez@chromium.org,sergeyu@chromium.org,kmackay@chromium.org

Change-Id: I9b5b2262d8ddc2edb706fb6fbec3d1fdc6d19563
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  851733 
Reviewed-on: https://chromium-review.googlesource.com/1105320
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568219}
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/BUILD.gn
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.h
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia_unittest.cc
[modify] https://crrev.com/1a7fde0c7fd4a1a1c6ed1465a9a0b3df1da1aa2c/chromecast/media/cma/backend/stream_mixer.cc

Comment 2 by holte@chromium.org, Jun 18 2018

Status: Fixed (was: Available)

Sign in to add a comment