New issue
Advanced search Search tips

Issue 853966 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CastMediaSinkServiceImpl incorrectly counts device connection failures

Project Member Reported by btolsch@chromium.org, Jun 18 2018

Issue description

The first call (i.e. not a retry) to CastMediaSinkServiceImpl::OpenChannels takes a nullptr for |backoff_entry|.  However, |backoff_entry| is notified of the connection failure in OnChannelOpened, but not created if null until OnChannelErrorMayRetry (where the failure_count() is initialized to 0).

This can be seen in the test CastMediaSinkServiceImplTest.TestOpenChannelFails: the default retry count is used (which is currently 3) and the test asserts that the number of retry failures is 4.


 

Sign in to add a comment