Issue metadata
Sign in to add a comment
|
compute_grit_inputs_for_analyze=true option does not work |
||||||||||||||||||||||
Issue description
The build is broken with the compute_grit_inputs_for_analyze=true option.
The error message is:
ninja: error: '../../third_party/blink/public/${cwd}/gen/third_party/blink/renderer/core/html.css', needed by 'gen/third_party/blink/public/resources/blink_resources.pak', missing and no known rule to make it
Probably caused by https://chromium.googlesource.com/chromium/src/+/93e774da116cc1bce515883fc28f012ccd905635
,
Jun 20 2018
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e578bf9377ac93fcf80add11866ac0f9af17f02 commit 8e578bf9377ac93fcf80add11866ac0f9af17f02 Author: Tom Anderson <thomasanderson@chromium.org> Date: Thu Jun 21 00:43:09 2018 Add missing cwd env var to grit_info and grit xmb This fixes the build with compute_grit_inputs_for_analyze=true which regressed after CL: https://chromium.googlesource.com/chromium/src/+/93e774da116cc1bce515883fc28f012ccd905635 BUG= 853961 R=dpranke Change-Id: I48e9297107cc0e543f00f1d6fa7e347bc39e5de3 Reviewed-on: https://chromium-review.googlesource.com/1105485 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#569099} [modify] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/tools/grit/grit/tool/xmb.py [modify] https://crrev.com/8e578bf9377ac93fcf80add11866ac0f9af17f02/tools/grit/grit_info.py
,
Jun 21 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by thomasanderson@chromium.org
, Jun 18 2018Status: Started (was: Assigned)