[WebUI Refresh] shared paper-button-style missing from pdf viewer dialog |
|||||
Issue description
,
Jun 18 2018
@scottchen: Do you have any test PDF document that triggers this dialog?
,
Jun 18 2018
,
Jun 18 2018
Fix at https://chromium-review.googlesource.com/c/chromium/src/+/1105401. Attaching screenshot.
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8bee0ec84a9a59a6e4821304e8f7edb2a9bb9034 commit 8bee0ec84a9a59a6e4821304e8f7edb2a9bb9034 Author: dpapad <dpapad@chromium.org> Date: Tue Jun 19 01:25:20 2018 WebUI MD Refresh: Update PDF password dialog buttons. Bug: 853958 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I1a9848f3bb1cba427e229b387516ffa1764c1096 Reviewed-on: https://chromium-review.googlesource.com/1105401 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#568280} [modify] https://crrev.com/8bee0ec84a9a59a6e4821304e8f7edb2a9bb9034/chrome/browser/resources/pdf/elements/viewer-password-screen/viewer-password-screen.html
,
Jun 19 2018
,
Jun 19 2018
Able to reproduce this issue on build without fix(69.0.3452.0), hence verifying the fix on latest canary 69.0.3465.0 on windows and Linux. NOTE: Unable to verify fix on Mac due to due to Issue 854114. Now observing submit button as showed in comment#4. Attaching screenshot for reference. Hence fix is working as expected in Linux and Windows. Not adding Verified labels as we can't verify on Mac due to blocking issue 854114. Thanks!
,
Jun 20 2018
Able to reproduce this issue on build without fix(69.0.3452.0), hence verifying the fix on latest canary 69.0.3466.0 on Mac. Now observing submit button as showed in comment#4. Attaching screenshot for reference. Adding Verified labels as this working as expected. Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scottchen@chromium.org
, Jun 18 2018