New issue
Advanced search Search tips

Issue 853953 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 849993



Sign in to add a comment

Use cros_display_config.mojom directly in Settings

Project Member Reported by steve...@chromium.org, Jun 18 2018

Issue description

Currently the Settings UI uses an extension API to handle display configuration:
https://cs.chromium.org/chromium/src/extensions/common/api/system_display.idl

This API is implemented in src/chrome and makes mojo calls to Ash using cros_display_config.mojom:
https://cs.chromium.org/chromium/src/ash/public/interfaces/cros_display_config.mojom

If we allow the Settings UI to make mojo calls and use cros_display_config.mojom directly, we will gain several advantages:
1) Less indirection / simpler code: Settings JS -> Ash instead of Settings JS -> Chrome -> Ash.
2) Less extension API code to maintain; The chrome.system.display is accessible from kiosk apps. Some of the API exists just to support Settings. Eliminating that support will make the API more concise, easier to maintain, and more secure.
3) More maintainable. New features only need to implement or extend the mojo API.


 
Blockedon: 849993
Some notes concerning the use of mojo in WebUI:
https://docs.google.com/document/d/1IVAX02m1biR-Jbw_eF5oBKeFsxjLocXtJLJ5cphgNmo/edit


Sign in to add a comment