[BlinkGenPropertyTrees] Form-related popup tests are crashing |
||
Issue descriptionTests in the following directories are failing: fast/forms/calendar-picker/ fast/forms/color/ fast/forms/page-popup/ fast/forms/select/ fast/forms/select-popup/ fast/forms/suggestion-picker/ Run with third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees fast/forms These seem to all be related. Many of them are hitting the following assert: FATAL:tree_synchronizer.cc(81)] Check failed: layer->transform_tree_index() != TransformTree::kInvalidNodeId (-1 vs. -1)
,
Jun 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c415398097e11f2ed653e0548b21f9982dee516 commit 0c415398097e11f2ed653e0548b21f9982dee516 Author: Philip Rogers <pdr@chromium.org> Date: Thu Jun 28 00:12:46 2018 [BlinkGenPropertyTrees] Wire up popup painting This patch fixes two bugs where popups were not painted: 1) Popups were not hooked up because the BGPT/SPV2 AttachRootLayer function was not implemented on WebPagePopupImpl. This has been implemented. 2) Popup layers were not painted. Popups are not attached to the viewport layers and were not found via the recursive paint walk. Popups are now special-cased so they are painted. A DCHECK has been added in layer_tree_host to make this sort of bug easier to debug. Instead of NPE in some random layer code, we now DCHECK. Bug: 853951 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia7bbcd4c27f860ada232d28c89ab672d60995aec Reviewed-on: https://chromium-review.googlesource.com/1117216 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#570960} [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/cc/trees/layer_tree_host.cc [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/third_party/blink/renderer/core/exported/web_page_popup_impl.cc [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/third_party/blink/renderer/core/exported/web_page_popup_impl.h [modify] https://crrev.com/0c415398097e11f2ed653e0548b21f9982dee516/third_party/blink/renderer/core/paint/compositing/paint_layer_compositor.cc
,
Jun 28 2018
|
||
►
Sign in to add a comment |
||
Comment 1 by pdr@chromium.org
, Jun 27 2018Status: Started (was: Available)