New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853948 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

R68 Branch Chrome PFQ Failing to build Chrome "no member named 'set_locale' in 'login_manager::UpgradeArcContainerRequest'"

Project Member Reported by bhthompson@google.com, Jun 18 2018

Issue description

First failure on the afternoon of June 13:
https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-chrome-pre-flight-branch%20release-R68-10718.B/builds/68

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos_release%2Fsamus-chrome-pre-flight-branch_release-R68-10718.B%2F68%2F%2B%2Frecipes%2Fsteps%2FBuildPackages%2F0%2Fstdout
...
chromeos-chrome-68.0.3440.26_rc-r1: FAILED: obj/components/arc/arc_base/arc_session_impl.o 
chromeos-chrome-68.0.3440.26_rc-r1: /home/chrome-bot/goma/gomacc x86_64-cros-linux-gnu-clang++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.27.0-gold -MMD -MF obj/components/arc/arc_base/arc_session_impl.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUSE_AURA=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -DCR_CLANG_REVISION=\"332838-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCR_SYSROOT_HASH=4e7db513b0faeea8fb410f70c9909e8736f5c0ab -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DWEBP_EXTERN=extern -DUSE_EGL -DTOOLKIT_VIEWS=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY -DSK_HAS_JPEG_LIBRARY -DSK_SUPPORT_GPU=1 -DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\" -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DLEVELDB_PLATFORM_CHROMIUM=1 -DMESA_EGL_NO_X11_HEADERS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DUCHAR_TYPE=uint16_t -DWEBRTC_NON_STATIC_TRACE_EVENT_HANDLERS=0 -DGTEST_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DNO_MAIN_THREAD_WRAPPING -DV8_USE_EXTERNAL_STARTUP_DATA -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebp/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libyuv/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/libwebm/source -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/encode -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/leveldatabase/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/mesa/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/ced/src -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/boringssl/src/include -I../../../../../../../home/chrome-bot/chrome_root/src/v8/include -Igen/v8/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc_overrides -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/webrtc -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -fcolor-diagnostics -fmerge-all-constants -fdebug-prefix-map=/var/cache/chromeos-chrome/chrome-src-internal/src/out_samus/Release=. -no-canonical-prefixes -m64 -march=x86-64 -Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -Wno-unused-lambda-capture -Wno-user-defined-warnings -Wno-enum-compare-switch -Wno-null-pointer-arithmetic -Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections -ffunction-sections -fno-omit-frame-pointer -g2 -ggnu-pubnames -fvisibility=hidden -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-header-guard -isystem../../../../../../../build/samus/usr/include/nss -isystem../../../../../../../build/samus/usr/include/nspr -isystem../../../../../../../build/samus/usr/include/dbus-1.0 -isystem../../../../../../../build/samus/usr/lib64/dbus-1.0/include -std=gnu++14 -fno-exceptions -fno-rtti --sysroot=../../../../../../../build/samus -fvisibility-inlines-hidden -pipe -pipe -pipe -march=corei7 -fdebug-info-for-profiling -D__google_stl_debug_vector=1 -Wno-unknown-warning-option -stdlib=libc++  -c ../../../../../../../home/chrome-bot/chrome_root/src/components/arc/arc_session_impl.cc -o obj/components/arc/arc_base/arc_session_impl.o
chromeos-chrome-68.0.3440.26_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/components/arc/arc_session_impl.cc:373:11: error: no member named 'set_locale' in 'login_manager::UpgradeArcContainerRequest'
chromeos-chrome-68.0.3440.26_rc-r1:   request.set_locale(locale_);
chromeos-chrome-68.0.3440.26_rc-r1:   ~~~~~~~ ^
chromeos-chrome-68.0.3440.26_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/components/arc/arc_session_impl.cc:375:13: error: no member named 'add_preferred_languages' in 'login_manager::UpgradeArcContainerRequest'
chromeos-chrome-68.0.3440.26_rc-r1:     request.add_preferred_languages(language);
chromeos-chrome-68.0.3440.26_rc-r1:     ~~~~~~~ ^
chromeos-chrome-68.0.3440.26_rc-r1: 2 errors generated.
chromeos-chrome-68.0.3440.26_rc-r1: 
...

Maybe related to https://b.corp.google.com/issues/67734479 ?

It looks like this bug merged stuff into 68 without merge review?
 
Ah these merged in https://b.corp.google.com/issues/76398711 

Can anyone confirm that reverting these will likely fix us?

Comment 2 by khmel@chromium.org, Jun 18 2018

Yes, it is related. However system api change was merged here: https://chromium-review.googlesource.com/c/chromiumos/platform/system_api/+/1098175

How Chrome does not see this change?

Comment 3 by khmel@chromium.org, Jun 18 2018

It seems we need to revert https://chromium-review.googlesource.com/c/chromium/src/+/1099371. But it is still unclear why it does not see changes from https://chromium-review.googlesource.com/c/chromiumos/platform/system_api/+/1098175

Comment 4 by khmel@chromium.org, Jun 18 2018

Cc: yusukes@chromium.org
Status: Started (was: Untriaged)
I did revert here: https://chromium-review.googlesource.com/c/chromium/src/+/1105359

Yusuke, do you know why system api change was not propagated to Chrome codebase?


You need to perform a manual DEPS roll for that: https://chromium-review.googlesource.com/c/chromium/src/+/1082054
It appears that system_api is a DEPS for Chrome

https://cs.chromium.org/chromium/src/DEPS?q=DEPS&sq=package:chromium&dr=C&l=536

As such we cannot just pick a change into it, the DEPS file on the branch needs to be manually updated to the new hash. This also means we need to be ok merging any additional changes that the new hash brings in. 

Comment 7 by khmel@chromium.org, Jun 18 2018

#6 - thanks for explanation. Will do it bit later.
Can we update the Chrome branch DEPS with the system_api R68 branch hash perhaps? I think that might fix us, if we can fix it that way we can avoid landing the revert.

Comment 9 by khmel@chromium.org, Jun 18 2018

and thanks for #5 :)

Comment 10 by khmel@chromium.org, Jun 18 2018

#8 - Revert is landed in crrev.com/c/1105359. We did reverts in almost the same time.


Comment 11 by khmel@chromium.org, Jun 25 2018

Status: Fixed (was: Started)
There are bunch of changes https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/f6223168..8fd2b32. I cannot safely rewind system_api in a DEPS. So I have to cancel apply locale on boot feature M68 merge.

This bug itself is fixed by reverting chromium change that uses not-published API.
Cc: khmel@chromium.org
 Issue 762553  has been merged into this issue.

Sign in to add a comment