New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 853943 link

Starred by 1 user
Status: Fixed
Owner:
█ trchen@chromium.org
Last visit > 30 days ago
Closed: Aug 20
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Border mask clip not applied

Project Member Reported by pdr@chromium.org, Jun 18 2018 
The following tests fail with image failures with BlinkGenPropertyTrees:
NEEDBUG fast/borders/border-radius-mask-canvas-all.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-canvas-border.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-canvas-padding.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-canvas-with-mask.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-canvas-with-shadow.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-canvas.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-video-ratio.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-video-shadow.html [ Failure ]
NEEDBUG fast/borders/border-radius-mask-video.html [ Failure ]

third_party/blink/tools/run_web_tests.py --debug --additional-driver-flag=--enable-blink-gen-property-trees fast/borders/border-radius-mask-canvas-all.html

It looks like we are not applying the border mask clip.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4725344b3549b876bb92eaf78027305784063807

commit 4725344b3549b876bb92eaf78027305784063807
Author: Tien-Ren Chen <trchen@chromium.org>
Date: Mon Jul 02 20:43:13 2018

[BlinkGenPropTrees] Apply replaced content clip to contents layer

Replaced contents are clipped by the content box. Normally this is not an
issue because we size the contents layer of a directly composited replaced
element to the clipped area. However in the case of a clip with rounded
corner, a clip still needs to be applied. Previously we incorrectly applied
the main layer state to its contents layer, which did not include the
rounded corner clip. This CL corrects that.

BUG= 853943 

Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id9a1a10e651ff2be73d43471ce94d85daf082f67
Reviewed-on: https://chromium-review.googlesource.com/1121538
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#571989}
[modify] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[add] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/WebKit/LayoutTests/flag-specific/enable-blink-gen-property-trees/fast/borders/overflow-hidden-border-radius-force-backing-store-expected.txt
[modify] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/blink/renderer/core/frame/local_frame_view.cc
[modify] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc
[modify] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/blink/renderer/platform/graphics/graphics_layer.cc
[modify] https://crrev.com/4725344b3549b876bb92eaf78027305784063807/third_party/blink/renderer/platform/graphics/graphics_layer.h

Comment 2 by pdr@chromium.org, Aug 18 

Is this fixed?

Comment 3 by trchen@chromium.org, Aug 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment