New issue
Advanced search Search tips

Issue 853940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Shouldn't show autocomplete attribute warnings for hidden fields

Project Member Reported by jyasskin@google.com, Jun 18 2018

Issue description

Chrome Version: 69.0.3452.0 (Official Build) dev (64-bit)
OS: Linux

What steps will reproduce the problem?
(1) Log into Github.
(2) Visit https://github.com/martinthomson/http-mice/pull/8
(3) Open the console

What is the expected result?

No autocomplete warnings or warnings only for visible fields. Since autofill shouldn't fill invisible fields anyway lest the user leak data they didn't intend to expose.

What happens instead?

Console output:

[DOM] Input elements should have autocomplete attributes (suggested: autocomplete='address-level2', confirm at https://goo.gl/6KgkJg)
<input type=​"text" name=​"required_field_3d76" id=​"required_field_3d76" hidden=​"hidden" class=​"form-control">​

[DOM] Input elements should have autocomplete attributes (suggested: autocomplete='address-level2', confirm at https://goo.gl/6KgkJg)
<input type=​"text" name=​"required_field_3d76" id=​"required_field_3d76" hidden=​"hidden" class=​"form-control">​
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa43848a4701d74a4ff4e742c6a4c7c6e61dab21

commit fa43848a4701d74a4ff4e742c6a4c7c6e61dab21
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Aug 01 19:26:52 2018

[Autofill] Turn off DOM Autocomplete suggestions by default.

Bug:  867893 ,  853940 , 869912

Change-Id: Ia9a2729682dd8cbbc662562ab4ce9f79bfc1fbd2
Reviewed-on: https://chromium-review.googlesource.com/1158720
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579897}
[modify] https://crrev.com/fa43848a4701d74a4ff4e742c6a4c7c6e61dab21/components/autofill/core/common/autofill_features.cc

Status: Fixed (was: Started)
They've been disabled for Stable users.

Sign in to add a comment