New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853938 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in SkOpAngle::segment

Project Member Reported by ClusterFuzz, Jun 18 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5636167710801920

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000d8
Crash State:
  SkOpAngle::segment
  SkOpSegment::findNextXor
  bridgeXor
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=567993:568015

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5636167710801920

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jun 18 2018

Components: Internals>Skia
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jun 18 2018

Cc: mbarbe...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 3 by ClusterFuzz, Jun 18 2018

Cc: carycl...@skia.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

fast path for pathops by caryclark@skia.org - https://skia.googlesource.com/skia/+/1bb47df4fc8edf62b0463d088214ed1ffb909ca9

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/560714336135d9bf851146ead65a6c68cf4220ed

commit 560714336135d9bf851146ead65a6c68cf4220ed
Author: Cary Clark <caryclark@skia.org>
Date: Tue Jun 19 12:58:00 2018

fix fuzzer bugs in pathops

one from clusterfuzz, one from Skia fuzzer

R=kjlubick@google.com
Bug:853938
Change-Id: If456bf45e4d75edecf4e4e8222ddcdaa301455f4
Reviewed-on: https://skia-review.googlesource.com/135701
Commit-Queue: Cary Clark <caryclark@skia.org>
Commit-Queue: Kevin Lubick <kjlubick@google.com>
Auto-Submit: Cary Clark <caryclark@skia.org>
Reviewed-by: Kevin Lubick <kjlubick@google.com>

[modify] https://crrev.com/560714336135d9bf851146ead65a6c68cf4220ed/src/pathops/SkOpSegment.cpp
[modify] https://crrev.com/560714336135d9bf851146ead65a6c68cf4220ed/src/pathops/SkOpCoincidence.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c4cafaa3576e437310e4f449d06bc111029cda9

commit 9c4cafaa3576e437310e4f449d06bc111029cda9
Author: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 19 16:40:54 2018

Roll src/third_party/skia f2030783094e..ba61029c5b49 (5 commits)

https://skia.googlesource.com/skia.git/+log/f2030783094e..ba61029c5b49


git log f2030783094e..ba61029c5b49 --date=short --no-merges --format='%ad %ae %s'
2018-06-19 caryclark@skia.org fix op fuzz timeout
2018-06-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 2dabb4a367c3..7df52383cfdf (1 commits)
2018-06-19 fmalita@chromium.org Use SkJSONWriter for viewer UI serialization
2018-06-19 caryclark@skia.org fix bookmaker files
2018-06-19 caryclark@skia.org fix fuzzer bugs in pathops


Created with:
  gclient setdep -r src/third_party/skia@ba61029c5b49

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:831647 , chromium:853938 
TBR=kjlubick@chromium.org

Change-Id: I553b529db946ce58832e209af4315efcca790386
Reviewed-on: https://chromium-review.googlesource.com/1106100
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568490}
[modify] https://crrev.com/9c4cafaa3576e437310e4f449d06bc111029cda9/DEPS

Project Member

Comment 6 by ClusterFuzz, Jun 20 2018

ClusterFuzz has detected this issue as fixed in range 568488:568508.

Detailed report: https://clusterfuzz.com/testcase?key=5636167710801920

Fuzzer: libFuzzer_skia_pathop_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x0000000000d8
Crash State:
  SkOpAngle::segment
  SkOpSegment::findNextXor
  bridgeXor
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=567993:568015
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=568488:568508

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5636167710801920

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jun 20 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 5636167710801920 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment