Add an accessibility label to the tab switch button |
||||||||
Issue descriptionThe label should describe the function of the button and also some context about what will be switched to. The current proposal is: "Switch to open tab [title]" Note that this is intentionally different than the button label "Switch to this tab" because "this" won't be helpful when read aloud by a screen reader. aleventhal, please correct me if I'm wrong, but all that's required is to make a new i18n string template with the text and title substitution above and call SetAccessibleName([new string]). It looks like Button already has an implementation of GetAccessibleNodeData(ui::AXNodeData* node_data) that will otherwise do the right thing.
,
Jul 12
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5 commit 1497a3e0cdf872b7ab7257e1d941da466c9b4eb5 Author: Kevin Bailey <krb@chromium.org> Date: Mon Jul 16 15:53:15 2018 [omnibox] Add accessibility label to suggestions with tab switch button For suggestions with a tab switch button, advertise the ability to tab over to it and press enter, in the accessibility label. Bug: 780835, 853911 , 853929 Change-Id: I91649d0517ab6e75970e49b5358e7d210c914071 Reviewed-on: https://chromium-review.googlesource.com/1106706 Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#575283} [modify] https://crrev.com/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5/components/omnibox/browser/autocomplete_match_type.cc [modify] https://crrev.com/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5/components/omnibox_strings.grdp
,
Jul 17
Note that the CL in #3 is the fix for issue 853911 . We still could probably use a description for the button itself when it's focused.
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/958453892e08b5b077c8fe8beb1ec4da107dcd14 commit 958453892e08b5b077c8fe8beb1ec4da107dcd14 Author: Kevin Bailey <krb@chromium.org> Date: Wed Jul 18 17:35:22 2018 [omnibox] Add tab switch button tooltip (and thus accessibility label) Bug: 780835, 853929 Change-Id: I9f5018fa6522d76ab7a8c57b635b084764f482db Reviewed-on: https://chromium-review.googlesource.com/1142129 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#576120} [modify] https://crrev.com/958453892e08b5b077c8fe8beb1ec4da107dcd14/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc
,
Jul 25
I'm not seeing the tooltip in the latest Canary and lpalmaro reports that there's no screen reader announcement. I wonder if the suggestion row is consuming the relevant UI events and preventing the tooltip and focus announcements from firing.
,
Jul 27
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e446d797f52afbd0315b415ef874ee9128946bfa commit e446d797f52afbd0315b415ef874ee9128946bfa Author: Kevin Bailey <krb@chromium.org> Date: Tue Jul 31 17:25:02 2018 [omnibox] Removed tooltip related override OmniboxPopupContentsView squelched any queries for tooltips by returning null from GetTooltipHandlerForPoint(). This change removes it. Doesn't seem to make a difference, but tooltips now work for the tab switch button and result view more generally. Bug: 853929 Change-Id: I995af95362bca165495052444b1432ee875fc5e7 Reviewed-on: https://chromium-review.googlesource.com/1155744 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#579452} [modify] https://crrev.com/e446d797f52afbd0315b415ef874ee9128946bfa/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/e446d797f52afbd0315b415ef874ee9128946bfa/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1725f96b533399b3b45a88477097df77120ebd2e commit 1725f96b533399b3b45a88477097df77120ebd2e Author: Kevin Bailey <krb@chromium.org> Date: Thu Aug 02 17:33:21 2018 [omnibox] Provide hint to tab switch button when "focused" The tab switch button isn't ever truly focused, since focus remains with the Omnibox. Thus, it never gets an accessibility event. This change causes an accessibility event to be generated when we trigger a simulated focus of the button. Bug: 853929 Change-Id: I7db6a8bd906a1785f047dc62b2beb03f14e22114 Reviewed-on: https://chromium-review.googlesource.com/1157071 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580231} [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_result_view.h [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.h [modify] https://crrev.com/1725f96b533399b3b45a88477097df77120ebd2e/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Aug 21
,
Aug 27
Hey, the switch to open tabs launch is blocked on this, so I'm bumping the priority.
,
Sep 3
A fix is in review at https://crrev.com/c/1185300.
,
Sep 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c9aa3e02228a245731ee592179b07944c4585f61 commit c9aa3e02228a245731ee592179b07944c4585f61 Author: Kevin Bailey <krb@chromium.org> Date: Thu Sep 06 03:57:18 2018 [omnibox] Accessibility announcements for un/focus tab switch button We were doing some of the work to generate accessibility announcements when "focusing" the tab switch button, but not all those necessary for MacOS. This CL attempts to fill in some of those gaps. Notably, the tab switch button will have to make its own call to the accessibility device on focus, and will have to manufacture a notification when focus returns to the result-view proper. TBR: tapted@chromium.org Bug: 853929 Change-Id: I8d81a8fa6a6528bb12c5e0ba3faff716610410b6 Reviewed-on: https://chromium-review.googlesource.com/1185300 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#589098} [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/chrome/browser/ui/views/omnibox/omnibox_result_view.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/chrome/browser/ui/views/omnibox/omnibox_tab_switch_button.h [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/chrome/browser/ui/views/omnibox/omnibox_view_views.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox/browser/autocomplete_match_type.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox/browser/autocomplete_match_type.h [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox/browser/autocomplete_match_type_unittest.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox/browser/omnibox_edit_model.h [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox/browser/omnibox_popup_model.cc [modify] https://crrev.com/c9aa3e02228a245731ee592179b07944c4585f61/components/omnibox_strings.grdp
,
Sep 20
,
Sep 26
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdonnelly@chromium.org
, Jul 11