New issue
Advanced search Search tips

Issue 853927 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: ----
Type: ----



Sign in to add a comment

Consolidate Command Id enums to app_menu_constants.h

Project Member Reported by newcomer@chromium.org, Jun 18 2018

Issue description

Move all app/launcher context menu command ids to app_menu_constants.h
 
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e82d8c8286554f56e09deef5db17eefdbac22849

commit e82d8c8286554f56e09deef5db17eefdbac22849
Author: Alex Newcomer <newcomer@chromium.org>
Date: Fri Jun 22 16:05:17 2018

cros: Move all app command id enums to app_menu_constants.h

Move all app command id enums to app_menu_constants.h.

Bug:  853927 
Change-Id: Ib269c5b35dfad205912a4d69eb84d84fd7c86857
Reviewed-on: https://chromium-review.googlesource.com/1107199
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569643}
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/ash/public/cpp/app_menu_constants.h
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/app_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/app_context_menu.h
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/app_context_menu_unittest.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/arc/arc_app_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/arc/arc_playstore_app_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/crostini/crostini_app_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/app_list/extension_app_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/arc_launcher_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/crostini_shelf_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/internal_app_shelf_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/launcher_context_menu.h
[modify] https://crrev.com/e82d8c8286554f56e09deef5db17eefdbac22849/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment