Accelerated Downloads UI: Issues with animation on Samsung pocket neo svelte |
|||||||||
Issue descriptionChrome Version: Chrome Canary 69.0.3464.0 OS: Android 4.1.2 What steps will reproduce the problem? (1)Download any file / Download multiple files The animation upon download completion has a colored circle around the checkmark. The circle should be light blue. It starts this way but then flashes black. On multiple downloads the icon disappears completely from the infobar (screenshot attached)
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f62e26d8bca1004bd58a24f15f4e505d8a62a3d commit 1f62e26d8bca1004bd58a24f15f4e505d8a62a3d Author: Shakti Sahu <shaktisahu@chromium.org> Date: Wed Jun 20 23:45:19 2018 Download Infobar : Animated vector drawable issues for older APIs For multiple download completion, we just show the check icon without starting animation. However since we are using AnimatedVectorDrawables, this leaves the icon blank for certain android versions if we don't use the animation. Refactored the XML file to separate out the path data and animations. Using VectorDrawable instead of AnimatedVectorDrawable to create the non-animated icon fixes this issue. Bug: 853918 Change-Id: Idd4c86be74a4b620e24f058aa9907253029c7c39 Reviewed-on: https://chromium-review.googlesource.com/1107251 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#569088} [add] https://crrev.com/1f62e26d8bca1004bd58a24f15f4e505d8a62a3d/chrome/android/java/res/drawable/infobar_download_complete.xml [modify] https://crrev.com/1f62e26d8bca1004bd58a24f15f4e505d8a62a3d/chrome/android/java/res/drawable/infobar_download_complete_animation.xml [modify] https://crrev.com/1f62e26d8bca1004bd58a24f15f4e505d8a62a3d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/1f62e26d8bca1004bd58a24f15f4e505d8a62a3d/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java
,
Jun 20 2018
,
Jun 20 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 21 2018
Can you verify this on canary? After this fix, there should be no animation issues on any of the android versions.
,
Jun 21 2018
Ok .. We will check
,
Jun 22 2018
Ping!
,
Jun 22 2018
Verified on Chrome:69.0.3469.0 Device:Samsung Galaxy S3 mini(GT-I8200N)/JDQ39,Samsung Galaxy Grand prime(SM-G530H)/LRX22G,LG G4(LG-H815)/MRA58K
,
Jun 25 2018
,
Jun 25 2018
,
Jun 25 2018
,
Jun 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc2c7c5375b50ade44404be56aa52d61b101478d commit bc2c7c5375b50ade44404be56aa52d61b101478d Author: Shakti Sahu <shaktisahu@chromium.org> Date: Mon Jun 25 21:32:20 2018 Download Infobar : Animated vector drawable issues for older APIs For multiple download completion, we just show the check icon without starting animation. However since we are using AnimatedVectorDrawables, this leaves the icon blank for certain android versions if we don't use the animation. Refactored the XML file to separate out the path data and animations. Using VectorDrawable instead of AnimatedVectorDrawable to create the non-animated icon fixes this issue. Bug: 853918 Change-Id: Idd4c86be74a4b620e24f058aa9907253029c7c39 Reviewed-on: https://chromium-review.googlesource.com/1107251 Reviewed-by: David Trainor <dtrainor@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#569088}(cherry picked from commit 1f62e26d8bca1004bd58a24f15f4e505d8a62a3d) Reviewed-on: https://chromium-review.googlesource.com/1113842 Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#517} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [add] https://crrev.com/bc2c7c5375b50ade44404be56aa52d61b101478d/chrome/android/java/res/drawable/infobar_download_complete.xml [modify] https://crrev.com/bc2c7c5375b50ade44404be56aa52d61b101478d/chrome/android/java/res/drawable/infobar_download_complete_animation.xml [modify] https://crrev.com/bc2c7c5375b50ade44404be56aa52d61b101478d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadInfoBarController.java [modify] https://crrev.com/bc2c7c5375b50ade44404be56aa52d61b101478d/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java
,
Jun 25 2018
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by shaktisahu@chromium.org
, Jun 18 2018Labels: M-69 OS-Android
Owner: shaktisahu@chromium.org
Status: Assigned (was: Untriaged)