New issue
Advanced search Search tips

Issue 853911 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Add tab switch announcement to accessibility label

Project Member Reported by jdonnelly@chromium.org, Jun 18 2018

Issue description

When an omnibox suggestion is selected, we'd like the accessibility label to announce the fact that tab switching is an option. Hopefully by announcing that a tab switch keyboard action is available, although what the keyboard shortcut will be is still being discussed. This text (e.g. "Shift+enter to switch to open tab") should be added after the existing description of title and URL.

To do this, special logic should be added to AutocompleteMatchType::ToAccessibilityLabel similar to how answers are detected here and either use an entirely new message template or append the result of a new template.

https://cs.chromium.org/chromium/src/components/omnibox/browser/autocomplete_match_type.cc?l=123&rcl=f27798f4413b6f5e01b3c07aba49b9717e3b0cee

aleventhal: Can you advise on how best to do this? Or put together a CL since you may be able to best judge the most effective approach? The thing that's not clear to me is that there's already different message templates based on whether it's a regular URL suggestion or one from a bookmark or the clipboard. Those special ones add text to the end that say "location from history", "bookmark" or "location from clipboard". Do we need two templates for each of those, with and without the new announcement? I'm hoping not, that we can have a new template just for the announcement and append the two results.

 
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 2 by k...@chromium.org, Jun 19 2018

Owner: k...@chromium.org
Status: Assigned (was: Available)
Labels: -Pri-3 Pri-2
Labels: Group-Omnibox
Update: shift-enter is going to be used to open suggestions in a new window. Instead, we should announce the existing keyboard navigation approach to executing a tab switch (tab navigation and the enter key).

So the new announcement, which should come after the text describing the title and URL, should be: "currently open, press tab then enter to switch to the open tab".
Labels: -Pri-2 Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5

commit 1497a3e0cdf872b7ab7257e1d941da466c9b4eb5
Author: Kevin Bailey <krb@chromium.org>
Date: Mon Jul 16 15:53:15 2018

[omnibox] Add accessibility label to suggestions with tab switch button

For suggestions with a tab switch button, advertise the ability to tab
over to it and press enter, in the accessibility label.

Bug: 780835,  853911 , 853929
Change-Id: I91649d0517ab6e75970e49b5358e7d210c914071
Reviewed-on: https://chromium-review.googlesource.com/1106706
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Kevin Bailey <krb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575283}
[modify] https://crrev.com/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5/components/omnibox/browser/autocomplete_match_type.cc
[modify] https://crrev.com/1497a3e0cdf872b7ab7257e1d941da466c9b4eb5/components/omnibox_strings.grdp

Labels: -Pri-1 Pri-3
Owner: aleventhal@chromium.org
Assigning to aleventhal to verify.
Status: Fixed (was: Assigned)
Verified by lpalmaro by email.

Sign in to add a comment