chrome/browser/vr/PRESUBMIT.py doesn't add bots for all vr changes |
||||
Issue descriptionFor https://chromium-review.googlesource.com/c/chromium/src/+/1104761, and the original change, win_optional_gpu_tests_rel wasn't added automatically. We should ensure it is added for changes to device/vr, and several other directories. In particular, this change modified code under chrome/browser/vr, so it should have triggered the specified bot.
,
Jun 20 2018
I think that would be useful change. Adding the hooks is simple. See https://cs.chromium.org/chromium/src/chrome/browser/vr/PRESUBMIT.py?rcl=e6e3030d9a5f2114fb63e6d691acfbed366fcc87&l=43. Assigning this to you, Bill.
,
Jul 4
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/209d1224fd2c86a443850edd8861efba7b60c38d commit 209d1224fd2c86a443850edd8861efba7b60c38d Author: Bill Orr <billorr@chromium.org> Date: Wed Jul 18 18:36:50 2018 Add new PRESUBMIT.py for running VR/XR tests when files change BUG= 853900 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e53ddd44240c46e0de1742ece470827eb4fcc10 Reviewed-on: https://chromium-review.googlesource.com/1139016 Reviewed-by: Brandon Jones <bajones@chromium.org> Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576146} [add] https://crrev.com/209d1224fd2c86a443850edd8861efba7b60c38d/device/vr/PRESUBMIT.py [add] https://crrev.com/209d1224fd2c86a443850edd8861efba7b60c38d/third_party/blink/renderer/modules/vr/PRESUBMIT.py [add] https://crrev.com/209d1224fd2c86a443850edd8861efba7b60c38d/third_party/blink/renderer/modules/xr/PRESUBMIT.py [add] https://crrev.com/209d1224fd2c86a443850edd8861efba7b60c38d/third_party/blink/renderer/platform/graphics/gpu/PRESUBMIT.py
,
Jul 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by billorr@chromium.org
, Jun 18 2018