New issue
Advanced search Search tips

Issue 853899 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 24
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Bad chromium_tests builder spec: Android Cronet builder Asan

Project Member Reported by gbeaty@chromium.org, Jun 18 2018

Issue description

The 'Android Cronet Builder Asan' builder spec located at https://chromium.googlesource.com/chromium/tools/build.git/+/master/scripts/slave/recipe_modules/chromium_tests/chromium_android.py specifies an invalid combination of chromium_config and chromium_apply_config that tries to apply multiple chromium config items from the compiler group:
main_builder_rel_mb -> main_builder_mb -> main_builder -> default_compiler
chromium_asan -> clang
 
Define "invalid".

The bot looks to be happily running builds:
https://ci.chromium.org/buildbot/chromium.android/Android%20Cronet%20Builder%20Asan/

And clang is the default compiler for android (and has been for a while now IIUC).

Comment 2 by gbeaty@chromium.org, Jun 19 2018

Nothing is wrong with the builder itself, just the spec in chromium_tests. None of the trybots refer to it and attempting to call configure_build with a BotConfig for that spec results in an exception because clang and default_compiler are both part of the "compiler" group and the recipe engine won't allow multiple items from the same group to be applied.

In https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/tests/builders.py, if you comment out the entry from the blacklist, you get the following error:
BadConf: config "chromium_asan" includes "clang", but ["clang" is a member of group "compiler", but ('default_compiler',) already ran]

Comment 3 by gbeaty@chromium.org, Jun 19 2018

Summary: Bad chromium_tests builder spec: Android Cronet builder Asan (was: Bad builder config: Android Cronet builder Asan)
Owner: bpastene@chromium.org
Status: Assigned (was: Untriaged)
Alright, it prob just needs a config tweak. I'll do that.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 21 2018

Status: Verified (was: Assigned)

Sign in to add a comment