ConnectionHelpTabHelper not catching interstitials for help center. |
||||||
Issue descriptionConnectionHelpTabHelper is not detecting when a navigation to the help center occurs due to an extra slash in the URL constant.
,
Jun 22 2018
As of Canary 69.0.3465.0 metric logs correctly in chrome://histograms. Requesting merge approval for 68 so we can get metrics from this release (since we missed 67 due to this bug).
,
Jun 22 2018
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 22 2018
,
Jun 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4be8720e66889a3e0064c3bd1e9d58700922fe8a commit 4be8720e66889a3e0064c3bd1e9d58700922fe8a Author: Carlos IL <carlosil@chromium.org> Date: Fri Jun 22 23:17:24 2018 Fixed typo in kHelpCenterConnectionHelpUrl Removed extra slash from help center URL, also updated the histogram enum to match the recommendation in base/metrics/histogram_macros.h Bug: 853897 Change-Id: Ie6372e1b535ae50d468680842e2213c9c404cbb0 Reviewed-on: https://chromium-review.googlesource.com/1104959 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#568160}(cherry picked from commit 3c59d0b5fc4c75021da266b7dfc4b12910b2c239) Reviewed-on: https://chromium-review.googlesource.com/1112598 Reviewed-by: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/branch-heads/3440@{#500} Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733} [modify] https://crrev.com/4be8720e66889a3e0064c3bd1e9d58700922fe8a/chrome/browser/ssl/connection_help_tab_helper.cc [modify] https://crrev.com/4be8720e66889a3e0064c3bd1e9d58700922fe8a/chrome/browser/ssl/connection_help_tab_helper.h
,
Jun 22 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Jun 18 2018