New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 853885 link

Starred by 2 users
Status: Fixed
Owner:
ryansturm@chromium.org
Closed: Jun 2018
Cc:
█ aposner@chromium.org
bengr@chromium.org
█ bshealy@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Change the heavy page capping InfoBar to a link instead of a button

Project Member Reported by ryansturm@chromium.org, Jun 18 2018 
Currently, the heavy page capping InfoBar uses a "stop loading" or "continue loading" button to allow the user to interact with the InfoBar. To match UX expectations, the button should be an inline link instead of a button
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16e5be88679bf43c997eaf856ef4a74f131bd678

commit 16e5be88679bf43c997eaf856ef4a74f131bd678
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Mon Jun 18 23:28:40 2018

Capping Pages InfoBar buttons -> InfoBar Links

Per UX decision, this change makes the InfoBar better for users.

Instead of using an InfoBar Button for pausing/resuming subresource
loading, we will use an InfoBar clickable link.

Bug:  853885 

Change-Id: Ia967baec922d0c363f48d26e057e121fa6ae969f
Reviewed-on: https://chromium-review.googlesource.com/1104722
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568229}
[modify] https://crrev.com/16e5be88679bf43c997eaf856ef4a74f131bd678/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_browsertest.cc
[modify] https://crrev.com/16e5be88679bf43c997eaf856ef4a74f131bd678/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate.cc
[modify] https://crrev.com/16e5be88679bf43c997eaf856ef4a74f131bd678/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate.h
[modify] https://crrev.com/16e5be88679bf43c997eaf856ef4a74f131bd678/chrome/browser/data_use_measurement/page_load_capping/page_load_capping_infobar_delegate_unittest.cc
[modify] https://crrev.com/16e5be88679bf43c997eaf856ef4a74f131bd678/chrome/browser/page_load_metrics/observers/page_capping_page_load_metrics_observer_unittest.cc

Comment 2 by ryansturm@chromium.org, Jun 18 2018

Status: Fixed (was: Started)
►

Sign in to add a comment