New issue
Advanced search Search tips

Issue 853883 link

Starred by 1 user
Status: Fixed
Owner:
jamescook@chromium.org
Closed: Jun 2018
Cc:
msw@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: 2018-06-25
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 841020



Sign in to add a comment

Enable keyboard shortcut viewer app when accessibility is disabled

Project Member Reported by jamescook@chromium.org, Jun 18 2018 
We're close to having everything except a11y working. As a trial, flip the default for the KSV app feature flag to on-by-default, but use the old version when incompatible a11y features are enabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11abc1adf573e24e45bea26ddd2da82696fed814

commit 11abc1adf573e24e45bea26ddd2da82696fed814
Author: James Cook <jamescook@chromium.org>
Date: Tue Jun 19 00:07:18 2018

chromeos: Turn shortcut viewer app on by default unless a11y enabled

The app version of the shortcut viewer works well, but we're still
waiting on some accessibility support. Turn the app on by default, but
use the old version if certain a11y features are enabled.

Bug:  853883 
Change-Id: I609b155da467bcb051d4d49d660de77863d0e1df
Reviewed-on: https://chromium-review.googlesource.com/1105077
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568242}
[modify] https://crrev.com/11abc1adf573e24e45bea26ddd2da82696fed814/ash/public/cpp/ash_features.cc
[modify] https://crrev.com/11abc1adf573e24e45bea26ddd2da82696fed814/chrome/browser/ui/ash/ksv/keyboard_shortcut_viewer_util.cc

Comment 2 by jamescook@chromium.org, Jun 19 2018

Status: Fixed (was: Started)

Comment 3 by monor...@bugs.chromium.org, Jun 25 2018 

The NextAction date has arrived: 2018-06-25
►

Sign in to add a comment