New issue
Advanced search Search tips

Issue 853874 link

Starred by 2 users
Status: Assigned
Owner:
jdragon....@gmail.com
Cc:
rayankans@chromium.org
peter@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unify proto <-> struct conversion logic in Background Fetch

Project Member Reported by rayankans@chromium.org, Jun 18 2018 
The field-copying logic is all over the place.

Comment 1 by jdragon....@gmail.com, Oct 5 

rayankans@: I wonder you're working on this. :)

Comment 2 by rayankans@chromium.org, Oct 12

Status: Fixed (was: Assigned)
This is actually fixed, sorry!

Comment 3 by jdragon....@gmail.com, Oct 12 

It's okay. Thanks!

Comment 4 by rayankans@chromium.org, Oct 12

Status: Available (was: Fixed)

Comment 5 by rayankans@chromium.org, Oct 12

Owner: jdragon....@gmail.com
Status: Assigned (was: Available)

Comment 6 by rayankans@chromium.org, Oct 12

Cc: rayankans@chromium.org
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be62008d74e8aa478d0574292efbb22c111d4b39

commit be62008d74e8aa478d0574292efbb22c111d4b39
Author: Jaeyong Bae <jdragon.bae@gmail.com>
Date: Mon Oct 15 14:44:41 2018

[Background Fetch] Apply proto <-> struct conversion logic

This patch is just a code simplification by applying conversion logic.

Bug: 853874
Change-Id: I3f9db03fa3b140856b388599ac65ed4ca0dadc98
Reviewed-on: https://chromium-review.googlesource.com/c/1278918
Reviewed-by: Rayan Kanso <rayankans@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#599637}
[modify] https://crrev.com/be62008d74e8aa478d0574292efbb22c111d4b39/content/browser/background_fetch/storage/get_initialization_data_task.cc
►

Sign in to add a comment