New issue
Advanced search Search tips

Issue 853867 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 3
Type: Bug
Proj-Servicification



Sign in to add a comment

network service seems to often pass process ID / routing IDs as uint32

Project Member Reported by dcheng@chromium.org, Jun 18 2018

Issue description

See https://cs.chromium.org/chromium/src/services/network/public/mojom/network_service.mojom.

It's not clear why, since the C++ type is a signed int32.

Also, what's the long-term plan for these process IDs / routing IDs? Are we going to try to get rid of them / refactor it at some point?

(tsepez, I'm assigning to you for now since I assume you have some context on this and I'm mostly just trying to gather info for now)

 

Comment 1 by mmenke@chromium.org, Jun 18 2018

Theoretically they'll be removed at some point.  Realistically, I think they're going to end up ossified to the extent that removing them will be at least 1-2 quarters of work, which may well not happen.

Comment 2 by tsepez@chromium.org, Jun 19 2018

Cc: tsepez@chromium.org mmenke@chromium.org
Owner: ----
Status: Available (was: Assigned)
Marking "available" per C1.

Comment 3 by dcheng@chromium.org, Jun 19 2018

OK, is there a reason they're passed (often) passed as uint32 in the mojom instead of int32 though?

Comment 4 by mmenke@chromium.org, Jun 19 2018

I have no idea.

Comment 5 by dxie@chromium.org, Jun 19 2018

Labels: Hotlist-KnownIssue OS-Android OS-Chrome OS-Linux OS-Mac

Sign in to add a comment