Disable flaky tests on mac10.10 |
|||||||
Issue description"telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWait" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVgsSBUZsYWtlIkt0ZWxlbWV0cnkuaW50ZXJuYWwuYWN0aW9ucy5hY3Rpb25fcnVubmVyX3VuaXR0ZXN0LkFjdGlvblJ1bm5lclRlc3QudGVzdFdhaXQM. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Jun 18 2018
,
Jun 18 2018
I'm not sure how to upload changes to third_party/catapult to disable these changes.
,
Jun 19 2018
,
Jun 19 2018
CL to disable is up at https://chromium-review.googlesource.com/c/catapult/+/1105819
,
Jun 19 2018
+nednguyen From https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=telemetry_unittests%20(with%20patch)&tests=telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWait and other bugs, it seems that these tests only recently started running on this bot. Is this a new bot? Or why the recent new failures?
,
Jun 19 2018
I think this is a new bot (probably related to the LUCI CQ migration)
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/c5ef6d834a158822a50c67dc117835b28b32be73 commit c5ef6d834a158822a50c67dc117835b28b32be73 Author: Marc Treib <treib@chromium.org> Date: Tue Jun 19 10:15:54 2018 Disable flaky ActionRunnerTest.testWait on Mac Bug: chromium:853865 Change-Id: I9772cee9c438805b635024cd0118a737606900bb Reviewed-on: https://chromium-review.googlesource.com/1105819 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/c5ef6d834a158822a50c67dc117835b28b32be73/telemetry/telemetry/internal/actions/action_runner_unittest.py
,
Jun 19 2018
,
Jun 19 2018
Juan: since we don't support mac10.10 on perf waterfall, can you update the disable condition to mac 10.10, then we just close this bug?
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8af319d6b53a9d8db9d50558582f4f5537f9622 commit a8af319d6b53a9d8db9d50558582f4f5537f9622 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 19 14:35:25 2018 Roll src/third_party/catapult 5ecb02850aa4..c5ef6d834a15 (1 commits) https://chromium.googlesource.com/catapult.git/+log/5ecb02850aa4..c5ef6d834a15 git log 5ecb02850aa4..c5ef6d834a15 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 treib@chromium.org Disable flaky ActionRunnerTest.testWait on Mac Created with: gclient setdep -r src/third_party/catapult@c5ef6d834a15 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:853865 TBR=sullivan@chromium.org Change-Id: I57b9ff27d91409e0c79cf2dde0ee583fa5662693 Reviewed-on: https://chromium-review.googlesource.com/1106019 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568441} [modify] https://crrev.com/a8af319d6b53a9d8db9d50558582f4f5537f9622/DEPS
,
Jun 20 2018
,
Jun 20 2018
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a2cee4816d7bfcc19abd3653e455a745cff1e9b4 commit a2cee4816d7bfcc19abd3653e455a745cff1e9b4 Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Wed Jun 20 11:32:09 2018 [Telemetry] Disable flaky tests on mac10.10 Platform mac10.10 is not currently supported on perf waterfall; disabling flaky unittests on it. Bug: chromium:853865 Change-Id: I4f8cb394034583bdefd47603b5ff0eb93dbf50c8 Reviewed-on: https://chromium-review.googlesource.com/1107705 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/a2cee4816d7bfcc19abd3653e455a745cff1e9b4/telemetry/telemetry/internal/actions/action_runner_unittest.py [modify] https://crrev.com/a2cee4816d7bfcc19abd3653e455a745cff1e9b4/telemetry/telemetry/internal/actions/play_unittest.py
,
Jun 20 2018
Just for our records, the following tests were disabled on mac10.10 due to flakiness: - telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWait - telemetry.internal.actions.action_runner_unittest.ActionRunnerTest.testWaitForElement - telemetry.internal.actions.play_unittest.PlayActionTest.testPlayWaitForEnded
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7e3fbfdcacb0f91816e1c589e3d0cd2207fd347 commit a7e3fbfdcacb0f91816e1c589e3d0cd2207fd347 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jun 20 13:17:05 2018 Roll src/third_party/catapult f153b902bec3..a2cee4816d7b (1 commits) https://chromium.googlesource.com/catapult.git/+log/f153b902bec3..a2cee4816d7b git log f153b902bec3..a2cee4816d7b --date=short --no-merges --format='%ad %ae %s' 2018-06-20 perezju@chromium.org [Telemetry] Disable flaky tests on mac10.10 Created with: gclient setdep -r src/third_party/catapult@a2cee4816d7b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:853865 TBR=sullivan@chromium.org Change-Id: I658c7b1910c92c4c900861f846404574d1891f85 Reviewed-on: https://chromium-review.googlesource.com/1107599 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568813} [modify] https://crrev.com/a7e3fbfdcacb0f91816e1c589e3d0cd2207fd347/DEPS |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by holte@chromium.org
, Jun 18 2018