New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 853860 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Download Infobar : Download complete animation seems grey instead of light blue

Project Member Reported by shaktisahu@chromium.org, Jun 18 2018

Issue description

Attached current animation video.
actual.mp4
4.2 MB View Download
Also, on Samsung mini galaxy, the opacity doesn't work well, hence the circle is showing up as a black circle instead.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac

commit 6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Tue Jun 19 18:54:39 2018

Download infobar : Animation improvements for API < 25

Fixed several issues with animation :
1 - Color of the completed download check mark was grey.
Changed it to light blue and smoothened the transition.
2 - For API < 25, when onAnimationEnd() is called,
isRunning() still returns true, hence restartAnimation
bails out early. This is a known android bug, workaround
 is to post the restart method.
3 - The fill animation was not being reset to correct
deep blue color at the beginning of every loop. Fixed it.

Bug:  853860 
Change-Id: Iff2414f2e94ed85711be19a13776db31e74292ee
Reviewed-on: https://chromium-review.googlesource.com/1105500
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568545}
[modify] https://crrev.com/6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac/chrome/android/java/res/drawable/infobar_download_complete_animation.xml
[modify] https://crrev.com/6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac/chrome/android/java/res/drawable/infobar_downloading_fill_animation.xml
[modify] https://crrev.com/6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java

Labels: Merge-Request-68
Project Member

Comment 5 by sheriffbot@chromium.org, Jun 19 2018

Labels: -Merge-Request-68 Hotlist-Merge-Review Merge-Review-68
This bug requires manual review: M68 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: prashanthpola@chromium.org krav...@chromium.org
kravula@ - Please verify on various versions of android. The animation should look exactly like the spec after this fix.

The fix for this bug fixes :
1 - The color of the circle for completed download (it should be blue as per UX)
2 - The grayed out animation (animation only showed up once) for devices less than N

ok .. we will test next canary.
we are able to see the expected results as mentioned in comment#6 , tested on latest M69 - 69.0.3466.0. 

Tested devices:
Pixel 2 XL / OPM2.171026.006.C1
Lenovo K8 NOTE / NMB26.54-35-2
Nexus 7 / MOB30X
Vivo V7 / N2G47H
OPPO A37fw / LMY47V
Samsung Galaxy Core 2 (SM-G355M) / KOT49H
Samsung Galaxy S3 (GT-I9300) / JSS15J
Karbonn Sparkle V / LMY47O
Samsung galaxy J7 (Sm-J700F) / MMB29K 

Comment 9 by cma...@chromium.org, Jun 21 2018

Labels: -Hotlist-Merge-Review -Merge-Review-68 Merge-Approved-68
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 22 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9fe172ba85967376761c40722652e9ecbd3ab1e4

commit 9fe172ba85967376761c40722652e9ecbd3ab1e4
Author: Shakti Sahu <shaktisahu@chromium.org>
Date: Fri Jun 22 20:36:46 2018

Download infobar : Animation improvements for API < 25

Fixed several issues with animation :
1 - Color of the completed download check mark was grey.
Changed it to light blue and smoothened the transition.
2 - For API < 25, when onAnimationEnd() is called,
isRunning() still returns true, hence restartAnimation
bails out early. This is a known android bug, workaround
 is to post the restart method.
3 - The fill animation was not being reset to correct
deep blue color at the beginning of every loop. Fixed it.

Bug:  853860 
Change-Id: Iff2414f2e94ed85711be19a13776db31e74292ee
Reviewed-on: https://chromium-review.googlesource.com/1105500
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568545}(cherry picked from commit 6a8f4d748d3bb5afdc8c198dae77877ac8fff8ac)
Reviewed-on: https://chromium-review.googlesource.com/1112597
Cr-Commit-Position: refs/branch-heads/3440@{#498}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/9fe172ba85967376761c40722652e9ecbd3ab1e4/chrome/android/java/res/drawable/infobar_download_complete_animation.xml
[modify] https://crrev.com/9fe172ba85967376761c40722652e9ecbd3ab1e4/chrome/android/java/res/drawable/infobar_downloading_fill_animation.xml
[modify] https://crrev.com/9fe172ba85967376761c40722652e9ecbd3ab1e4/chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadProgressInfoBar.java

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
we are able to see the expected results as mentioned in comment#6 , tested on latest M68 -68.0.3440.40. Hence closing this issue. Thanks 

Sign in to add a comment