New issue
Advanced search Search tips

Issue 853846 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 851555



Sign in to add a comment

Open Settings in the search result of Home launcher will not clear search result

Project Member Reported by wutao@chromium.org, Jun 18 2018

Issue description

Opening internal apps or extension apps in home launcher will close launcher.
 

Comment 1 by wutao@chromium.org, Jun 18 2018

Cc: weidongg@chromium.org omrilio@chromium.org
Owner: wutao@chromium.org
I probably will fix this bug at the same time when fixing  bug 851555 .
Status: WontFix (was: Available)
As discussed offline, opening search results will not close search result page. After switching back to the launcher, launcher will reset to fullscreen mode by animating to close search result page, which looks like that the launcher was closed.
I would mark this as wont fix.

Comment 3 by wutao@chromium.org, Jun 18 2018

Labels: -Pri-1 Pri-3
Owner: weidongg@chromium.org
Change owner back to weidongg@ in case we want to change the "close search result behavior" in the future.

Comment 4 by wutao@chromium.org, Jun 18 2018

Summary: Open Settings in the search result of Home launcher will not clear search result (was: Open shortcut viewer app or settings in Home launcher will close launcher)
Labels: home-launcher
Status: Assigned (was: WontFix)
Reopen it because it is still a bug we need to fix: App launcher should be reset after an app is launched.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee6d9cc2c26efccbed9439090022c66b732c03d3

commit ee6d9cc2c26efccbed9439090022c66b732c03d3
Author: Weidong Guo <weidongg@chromium.org>
Date: Wed Aug 15 16:55:00 2018

Fix homecher launching app behavior

Changes:
In homecher, folder or search result page is closed when an app is
launched or a search result is opened.

Bug:  853846 
Change-Id: I92edf732b01bb9c5b0f97ff2206bd09b2b6130ca
Reviewed-on: https://chromium-review.googlesource.com/1175417
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583282}
[modify] https://crrev.com/ee6d9cc2c26efccbed9439090022c66b732c03d3/ash/app_list/app_list_controller_impl.cc
[modify] https://crrev.com/ee6d9cc2c26efccbed9439090022c66b732c03d3/ash/app_list/views/app_list_view.cc
[modify] https://crrev.com/ee6d9cc2c26efccbed9439090022c66b732c03d3/ash/app_list/views/app_list_view.h

Status: Fixed (was: Assigned)

Sign in to add a comment