Refactor MediaStreamRemoteVideoSource handling WebRTC types |
||
Issue descriptionCurrently we have lots of if/else statements. In preparation for future types, it is better to refactor this class.
,
Jun 18 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/645cc6a813dd418c6adae777796e831f1097c6e6 commit 645cc6a813dd418c6adae777796e831f1097c6e6 Author: Emircan Uysaler <emircan@chromium.org> Date: Tue Jun 19 16:19:47 2018 Revert "Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource" This reverts commit e048eba0dd38aadbbb18f721c402ae1b1b605dc5. Reason for revert: Speculative revert as a regression is detected in this range. https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICQ2ajFuAoM Original change's description: > Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource > > This CL cleans up this class in preparation for future types to be added. > > Bug: 853843 > Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 > Reviewed-on: https://chromium-review.googlesource.com/1104965 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568165} TBR=emircan@chromium.org,chfremer@chromium.org Change-Id: Ic71cc3094e0e79572c2045a4c4464dd5b5bbd114 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 853843 Reviewed-on: https://chromium-review.googlesource.com/1106397 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568480} [modify] https://crrev.com/645cc6a813dd418c6adae777796e831f1097c6e6/content/renderer/media/webrtc/media_stream_remote_video_source.cc [modify] https://crrev.com/645cc6a813dd418c6adae777796e831f1097c6e6/content/renderer/media/webrtc/media_stream_remote_video_source.h [modify] https://crrev.com/645cc6a813dd418c6adae777796e831f1097c6e6/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc
,
Jun 20 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6610695303037b443f78b962a4b14f6a3781a77 commit b6610695303037b443f78b962a4b14f6a3781a77 Author: Emircan Uysaler <emircan@chromium.org> Date: Wed Jun 20 04:06:09 2018 Reland "Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource" This is a reland of e048eba0dd38aadbbb18f721c402ae1b1b605dc5 Original change's description: > Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource > > This CL cleans up this class in preparation for future types to be added. > > Bug: 853843 > Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 > Reviewed-on: https://chromium-review.googlesource.com/1104965 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568165} Bug: 853843 Change-Id: Ic7ff7acebc126438529c51d48d9db2b118e10887 TBR: chfremer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1106943 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568722} [modify] https://crrev.com/b6610695303037b443f78b962a4b14f6a3781a77/content/renderer/media/webrtc/media_stream_remote_video_source.cc [modify] https://crrev.com/b6610695303037b443f78b962a4b14f6a3781a77/content/renderer/media/webrtc/media_stream_remote_video_source.h [modify] https://crrev.com/b6610695303037b443f78b962a4b14f6a3781a77/content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jun 18 2018