pbos@ Could you attach the output of the following?

$ sudo apt install xsettingsd
$ dump_xsettings

pbos@spectre:~$ dump_xsettings 
No current owner for _XSETTINGS_S0 selection

Anything else I can run? This might be using the GTK fallback theme if there's no theme running.

For context, I'm running i3 and I haven't started my settings daemon. I think. System's been gradually busted through updates and I've on not kept up.

Ah, yeah sounds like it's using the default theme.  Though I'm not sure what the default would be.  You could try this:

$ sudo apt install gtk-3-examples
$ GTK_DEBUG=interactive gtk3-widget-factory

Then in the "Visual" tab, there should be a "GTK+ Theme" entry.

Looks like Raleigh according to random internet searches.: http://i.stack.imgur.com/dm0BV.png

The example window (in gtk3-widget-factory) looks somewhat busted when selecting the Raleigh theme. Seems like Adwaita is the default theme for GTK3. The screenshots I posted of the theme are not unlikely using GTK2.

Hm.. For me the Raleigh theme looks like the attached.  There's no borders around any of the tabs, so it appears we're matching the theme properly.

For Linux, the philosophy has been to not try to fix broken themes (because this just breaks non-broken ones), so I'm closing this issue.

+timbrown could probably tell you how to change the GTK theme on i3.

Deleted: Screenshot from 2018-06-18 12-02-07.png 97.7 KB

	Screenshot from 2018-06-18 12-02-07.png 97.7 KB View Download

Seems a bit scarier if it's really broken with "the default theme" rather than a random broken theme?

I think Adwaita is supposed to be the default (and it's certainly not broken, I've been using Chrome+Adwaita for years).  Not sure why your default theme is Raleigh :S

Here's my default theme in Cinnamon, is this similar to yours or is my theme service somehow busted? In this setting I can't really tell which my current theme is as the difference seems to be about a 10% lighter grey.

Deleted: cinnamon-default.png 16.8 KB

	cinnamon-default.png 16.8 KB View Download

I'm not 100% my theme is Raleigh in Chrome, I just compared it to the GTK2 app, so ignore Raleigh for now. If you turn on chrome://flags -> upcoming ui features, is that working reasonably for you?

> Here's my default theme in Cinnamon, is this similar to yours or is my theme service somehow busted?

That's how it looks for me with the light Adwaita theme (I usually use the dark variant).

I'll take a closer look to see where we're getting these colors from.

I'm not sure if my Dev release is old, I think the inactive tab background has gone away and we're just painting onto the window frame (at least on Windows currently). That should give a slightly better contrast but these grey-on-greys is still very low contrast.

Issue 852724 has been merged into this issue.

I have what sounds like a similar issue. The focused tab is a different color, but it is so similar that I have a hard time distinguishing which is focused.

Screenshot attached.

Deleted: faded-tab.png 8.5 KB

	faded-tab.png 8.5 KB View Download

+bettes

A lot of themes used on GTK/Linux give pretty bad contrast between the toolbar and the tabstrip background.  For example, I've attached how my theme looks pre/post md-refresh.  Before, we used to render a border around the tabs, and this was OK, although it was still sometimes difficult to identify the active tab when the active/inactive colors were similar.

To fix these issues, I propose (idea taking from pkasting) that we draw a border only around the active tab when the contrast ratio is <1.4.  Something like my second picture.  Is this something you would approve of?

Deleted: Screenshot from 2018-07-12 15-28-04.png 226 KB

	Screenshot from 2018-07-12 15-28-04.png 226 KB View Download

Deleted: Screenshot from 2018-07-12 15-30-52.png 87.9 KB

	Screenshot from 2018-07-12 15-30-52.png 87.9 KB View Download

Yeah, I support this.  We have code already to calculate the relevant border color and there's some half-working code to do borders, although it needs a couple days of work to make it functional.  If we just do a border along the top of the toolbar and around the active tab, it's pretty similar to the feel of what refresh is going for (as opposed to doing borders on every tab).  And if we limit the border to very-low-contrast cases, we don't impact the default look.

Broadening to cross-platform.

 Issue 863263  has been merged into this issue.

I spoke with chrishtr@ and we found that today's ToT has the expected UI which would provide the necessary contrast to fix this bug. Are we to presume these changes will reach Dev?

For the record, I consider drawing borders the very last option to bringing contrast to the tabstrip. We should exhaust all possible options beforehand.

The attachment has today (left) next to ToT (right). 

Deleted: unnamed (1).png 19.5 KB

	unnamed (1).png 19.5 KB View Download

> I spoke with chrishtr@ and we found that today's ToT has the expected UI which would provide the necessary contrast to fix this bug. Are we to presume these changes will reach Dev?

It looks different because the browser on the right is using the classic theme (chrome://settings Appearance>Themes>Use GTK+/Classic).  If you toggle the setting to use the GTK theme, it should look the same as the browser on the left.

Also, let's drop the proposed contrast minimum from 1.4 to 1.3 to avoid affecting the default theme.  I think the default theme's contrast is too low to make distinguishing the active tab easy, and there's some feedback externally accordingly, but I'm not yet sure that's a battle I want to fight at all, and most certainly not on this bug; I was hoping to avoid changing the default look in any way.

 Issue 863857  has been merged into this issue.

 Issue 863010  has been merged into this issue.

Issue 863811 has been merged into this issue.

As I noted in 86310, this may breach the Ontarians With Disabilities Act, in the opinion of a friend who inspects web sites for ODA  compliance. 

Please note that this is not a legal opinion on his or my part: please seek advice of a lawyer appropriate to your legal regime. My understanding is that the ODA is less stringent than the US equivalent.

Here's a custom theme which demonstrates this issue: https://chrome.google.com/webstore/detail/quilt/ofholagheebdhalaonjopcfcedggjooo

We have approval from GM2 leadership to implement this enough to get screenshots and make sure bettes@ is OK with things.

Ok, thanks Peter.  I will try to get a prototype working.

Feel free to work with me on this -- you may need some of the stuff I'm currently doing with themes to accurately check the contrast ratio, and much of the rest will involve fixes/changes in tab.cc that I'm pretty sure I understand how to make.

Here's an initial prototype.  Does this lg to everyone?

Deleted: dark_border.mp4 295 KB

	dark_border.mp4 295 KB View Download

Deleted: light_border.mp4 310 KB

	light_border.mp4 310 KB View Download

Deleted: hidpi.mp4 400 KB

	hidpi.mp4 400 KB View Download

From the person whose opinion doesn't matter as much:

Yeah.  There's some drawing issues, and we should maybe be trying to use the same color as tab separators, but I think the shape is OK, and as long as this only kicks in for the worst-behaved themes, I'm fine with it.

I used a borrowed "simulate person with poor vision" app and they all looked good to me.

--dave

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026

commit 7af9ca12fe8c5e6060c9d0e5617ed824f67d9026
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 07 00:42:19 2018

Draw border around active tab when tab/frame contrast is very low

BUG= 853841 
R=pkasting

Change-Id: Iac25d17618487e03aac7bfa6f54e98848ce47c24
Reviewed-on: https://chromium-review.googlesource.com/1159385
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581061}
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026/chrome/browser/ui/views/toolbar/toolbar_view.cc

How is this change looking in canary? Also this P2, why it is needed for M69? 

We realized there's still a few issues we need to iron out.  However, we would still like to ship this as part of the refresh UI for M69.

How safe is the change to merge to M69? 

Also, should be P1

> How safe is the change to merge to M69?

Not safe until the blocked on bugs get fixed.  Hopefully should be within 1 or 2 days.

Pls update the bug once blocked bugs are fixed, holding off M69 approval until then. If merge gets in latest by 4:00 PM PT Monday (08/13), we can pick it up for next week beta. Thank you.

This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741

commit 39a62a9108120339bc58dd532eeb3517a450d741
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed Aug 08 05:03:07 2018

Let the BrowserNonClientFrameView decide whether to draw strokes

This CL:

* Uses the active frame color for deciding when to draw a stroke around the
  active tab
* Prevents strokes from being draw on Aero glass themes
* (Hopefully) Fixes a crash and flaky test

BUG= 853841 ,871739, 871883 , 871910 
R=pkasting

Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c
Reviewed-on: https://chromium-review.googlesource.com/1166546
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581477}
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/infobars/infobars_browsertest.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/39a62a9108120339bc58dd532eeb3517a450d741/chrome/browser/ui/views/tabs/tab_strip_controller.h

Merge approved, M69.

Adding back to "Merge-Review-69", pls see comment #40. Thank you.

thomasanderson@, any update on blocking  bugs based on comment #39? Also how many merges we're expecting for M69 including merges for blocking bugs?

Pls note M69 is very close to stable launch, so we're only taking absolutely critical and fully safe merges in to minimize the risk. Thank you. 

We're still fixing some bugs.  This would require about 5 merges, and unfortunately I cannot guarantee that they will be risk-free.

I think we still probably need this for GTK to not be broken in M69.  We can maybe omit some of the merges (e.g. we don't need tab curves to look perfect).  Let's try and get to the point where we can list exactly what would need to be merged back and then evaluate.

Re #53, sounds good. Pls update the bug when list of merges is ready. thank you.

Note: We're planning to cut M69 Beta RC  @ 1:00 PM PT on Wednesday (08/15) for release on Thursday (08/16). So if approved merges are in before then, we can pick them up for this week beta release. 

All of the blockers are now fixed.  The CLs that need to be merged are:

https://chromium.googlesource.com/chromium/src.git/+/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026
https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741
https://chromium.googlesource.com/chromium/src.git/+/2d4420008d2c3a2cb08ecfb4be6a997fc10df7b7
https://chromium.googlesource.com/chromium/src.git/+/c415fd93b2a5d6136cc0a6f794b8651ff7768623
https://chromium.googlesource.com/chromium/src.git/+/6044ebe19878468f70a22d15dbef7b7987f25bf5

The last 2 are not strictly necessary, but I would prefer having those merged too.

Lets plan to merge only first 3 which are strictly necessary. All below changes are baked/verified in canary and safe to merge now?

https://chromium.googlesource.com/chromium/src.git/+/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026
https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741
https://chromium.googlesource.com/chromium/src.git/+/2d4420008d2c3a2cb08ecfb4be6a997fc10df7b7

> All below changes are baked/verified in canary and safe to merge now?

The first two are.  The third has only been in for a day, but there appears to be no issues so far.  Also the third has some Linux-only changes, but Linux does not have a canary channel to test on.

Approving merge for All 3 CLs listed below to M69 branch 3497 based on comment #57. Pls merge ASAP.

https://chromium.googlesource.com/chromium/src.git/+/7af9ca12fe8c5e6060c9d0e5617ed824f67d9026
https://chromium.googlesource.com/chromium/src.git/+/39a62a9108120339bc58dd532eeb3517a450d741
https://chromium.googlesource.com/chromium/src.git/+/2d4420008d2c3a2cb08ecfb4be6a997fc10df7b7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243

commit 4ece7bb0fb8ff7f5fe2e745680d45bc85907f243
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 14 19:06:57 2018

[Merge to M69] Draw border around active tab when tab/frame contrast is very low

>  BUG= 853841 
>  R=pkasting
>
>  Change-Id: Iac25d17618487e03aac7bfa6f54e98848ce47c24
>  Reviewed-on: https://chromium-review.googlesource.com/1159385
>  Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>  Reviewed-by: Peter Kasting <pkasting@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#581061}

BUG= 853841 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If20d40b1aaf31229e2ce38f1d277366b438368c4
Reviewed-on: https://chromium-review.googlesource.com/1174969
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#621}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/ash/tab_scrubber.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/new_tab_button.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab_controller.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab_strip_controller.h
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/tabs/tab_unittest.cc
[modify] https://crrev.com/4ece7bb0fb8ff7f5fe2e745680d45bc85907f243/chrome/browser/ui/views/toolbar/toolbar_view.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcee3ef4289ecb833550c694d15bf535cb334704

commit fcee3ef4289ecb833550c694d15bf535cb334704
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Aug 14 19:10:10 2018

[Merge to M69] Let the BrowserNonClientFrameView decide whether to draw strokes

>  This CL:
>
>  * Uses the active frame color for deciding when to draw a stroke around the
>    active tab
>  * Prevents strokes from being draw on Aero glass themes
>  * (Hopefully) Fixes a crash and flaky test
>
>  BUG= 853841 ,871739, 871883 , 871910 
>  R=pkasting
>
>  Change-Id: I120f33a135a82c82ab4ae97d5ca56b790894b11c
>  Reviewed-on: https://chromium-review.googlesource.com/1166546
>  Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
>  Reviewed-by: Peter Kasting <pkasting@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#581477}

BUG= 853841 ,871739, 871883 , 871910 
TBR=pkasting
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I5a301e513742eb37dbf89a98fd694475a789a6e5
Reviewed-on: https://chromium-review.googlesource.com/1174991
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#622}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/browser_non_client_frame_view.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/frame/glass_browser_frame_view.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/browser_tab_strip_controller.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/fake_base_tab_strip_controller.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.cc
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip.h
[modify] https://crrev.com/fcee3ef4289ecb833550c694d15bf535cb334704/chrome/browser/ui/views/tabs/tab_strip_controller.h

Third CL landed under a different bug:
https://chromium.googlesource.com/chromium/src.git/+/7cae60a2e09f4117fa74536618f4e0617b4f23b8

 Issue 862605  has been merged into this issue.

I got a build at some point that had this bug fixed, but it seems to have regressed since, was this change reverted?

In fact, today I upgraded my chromebook (pixel2) to r69, and even with the default theme the contrast for the selected tab is very low, at least with full brightness.

@63: Screenshots of cases where you think the behavior is buggy?  I can at elast tell you whether you're seeing something intentional.

I'd added some earlier screenshots before these changes in issue 863811, but the behavior has changed.

The border is now visible in a non-incognito tab, albeit only _just_ on my laptop's screen. Similar to what I said in issue 863811 it's simpler to look for the tab separators than anything else.

Screenshot is from the official Debian repo, unstable version 71.0.3554.4-1.

Deleted: chrome-ui-low-contrast-tabs.png 9.5 KB

	chrome-ui-low-contrast-tabs.png 9.5 KB View Download

Tom, can you check the GTK border color picking algorithm?  The contrast of stroke-on-tab in comment 65 is 1.21, which seems really low, considering that we try to draw the stroke when the tab-on-frame contrast is <= 1.3, so I'd think the stroke contrast should be higher than that.

c#65: which GTK theme are you using?  You can find out with:
$ gtk-query-settings gtk-theme-name

Theme is "Breeze-Dark", as provided by the Debian breeze-gtk-theme package, version 5.13.5-1.

X-reffing video for CL https://chromium-review.googlesource.com/c/chromium/src/+/1278144

Deleted: stroke_demo.mp4 373 KB

	stroke_demo.mp4 373 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971df2a0b77860b58cc10d6c813855e60528de1b

commit 971df2a0b77860b58cc10d6c813855e60528de1b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Oct 16 23:16:23 2018

[GTK] Enforce a minimum tab stroke contrast ratio

BUG= 853841 
R=pkasting

Change-Id: Ifb680152768ea9214861b63b9f55181c2ad1ed6b
Reviewed-on: https://chromium-review.googlesource.com/c/1278144
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600180}
[modify] https://crrev.com/971df2a0b77860b58cc10d6c813855e60528de1b/chrome/browser/themes/theme_service.cc
[modify] https://crrev.com/971df2a0b77860b58cc10d6c813855e60528de1b/chrome/browser/ui/libgtkui/gtk_ui.cc
[modify] https://crrev.com/971df2a0b77860b58cc10d6c813855e60528de1b/ui/gfx/color_utils.cc
[modify] https://crrev.com/971df2a0b77860b58cc10d6c813855e60528de1b/ui/gfx/color_utils.h
[modify] https://crrev.com/971df2a0b77860b58cc10d6c813855e60528de1b/ui/gfx/color_utils_unittest.cc