New issue
Advanced search Search tips

Issue 853803 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 887113
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Add Mount option to pass login credentials

Project Member Reported by baileyberro@chromium.org, Jun 18 2018

Issue description

Add an explicit option to the SmbShare Mount Dialog to pass a user's login credentials if they are ChromAD. 

When mounting with Kerberos, hostnames must stay unresolved and be resolved by the domain controller/DNS so that ticket operations can be handled correctly. Tickets correlate to a hostname rather than an ip address.
 
Labels: smb-native
Status: Assigned (was: Available)
Labels: -Pri-3 M-70 Pri-1
Status: Started (was: Assigned)
Starting this since we have M70 on it
Labels: -M-70 M-71
Moving to M71- Waiting on UX input
Components: Enterprise
Mergedinto: 887113
Status: Duplicate (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/877850b330762b3cc3e7be95648f722722f6ea93

commit 877850b330762b3cc3e7be95648f722722f6ea93
Author: Bailey Berro <baileyberro@chromium.org>
Date: Wed Oct 03 16:57:56 2018

Add dropdown to select authentication method for Smb Share

- Adds a dropdown to select authentication method that is only visible
to chromad users.
- This change has no effect on non-chromad users
- The KerberosAuthentication_ boolean will be passed to
SmbService::Mount in a following CL

Bug:  chromium:853803 
Change-Id: Icc9ec65a4eb0ae20e90088f2767c7fda17578a0a
Reviewed-on: https://chromium-review.googlesource.com/1191923
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596257}
[modify] https://crrev.com/877850b330762b3cc3e7be95648f722722f6ea93/chrome/app/settings_strings.grdp
[modify] https://crrev.com/877850b330762b3cc3e7be95648f722722f6ea93/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.html
[modify] https://crrev.com/877850b330762b3cc3e7be95648f722722f6ea93/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/877850b330762b3cc3e7be95648f722722f6ea93/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/877850b330762b3cc3e7be95648f722722f6ea93/chrome/test/data/webui/settings/smb_shares_page_tests.js

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db8531462b66fe03d431c0dcdb479ef30618716

commit 2db8531462b66fe03d431c0dcdb479ef30618716
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Oct 11 04:25:16 2018

Pass authMethod to SmbHandler::smbMount

- Passes the authMethod string to smbMount.
- This string will be used to determine whether chromad kerberos should be
used by SmbService to authenticate to a share.

Bug:  chromium:853803 
Change-Id: Ib6a329529904902dc26982346e0130640795778f
Reviewed-on: https://chromium-review.googlesource.com/c/1258973
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#598669}
[modify] https://crrev.com/2db8531462b66fe03d431c0dcdb479ef30618716/chrome/browser/resources/settings/downloads_page/add_smb_share_dialog.js
[modify] https://crrev.com/2db8531462b66fe03d431c0dcdb479ef30618716/chrome/browser/resources/settings/downloads_page/smb_browser_proxy.js
[modify] https://crrev.com/2db8531462b66fe03d431c0dcdb479ef30618716/chrome/browser/ui/webui/settings/chromeos/smb_handler.cc
[modify] https://crrev.com/2db8531462b66fe03d431c0dcdb479ef30618716/chrome/test/data/webui/settings/smb_shares_page_tests.js

Sign in to add a comment