Some ProfileBrowserTests use URLFetchers |
||||
Issue descriptionThe following tests all user URLFetchers, which are deprecated: ProfileBrowserTest.SeparateMediaCache ProfileBrowserTest.URLFetcherUsingMainContextDuringIncognitoTeardown ProfileBrowserTest.URLFetcherUsingMainContextDuringShutdown ProfileBrowserTest.URLFetcherUsingMediaContextDuringShutdown The first is a short-term test of a field trial, so is presumably fine. The others are teardown tests, which are perhaps less interesting when the NetworkService is enabled. If we're still interested in testing those cases, we should perhaps have NetworkService unittests for them instead (Not positive of that, haven't really thought about it).
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cb02821074ba14de3d6a503ef204b694b25017a4 commit cb02821074ba14de3d6a503ef204b694b25017a4 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jun 19 15:40:30 2018 Annotate many of the browser_tests disabled under the NetworkService. Also remove a couple that either no longer exist, have been disabled generally due to flakiness, or are now passing. BUG= 844950 , 844951 , 844952 , 853251 , 844928 , BUG= 843205 , 844949 , 844925 , 844939 , 821021, BUG=853798, 844973 , 844927 , 844926 , 844950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I094a012fe2076c7badf86a094140c7d74db183be Reviewed-on: https://chromium-review.googlesource.com/1104802 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#568464} [modify] https://crrev.com/cb02821074ba14de3d6a503ef204b694b25017a4/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jun 19 2018
,
Sep 4
,
Sep 4
The only test still doing this is SeparateMediaCache, which I don't think we care about (There is no NetworkContext for the media request context, and we're experimenting with getting rid of the separate media cache). Since there's no media NetworkContext, can't really update the test sanely.
,
Sep 4
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mmenke@chromium.org
, Jun 18 2018