New issue
Advanced search Search tips

Issue 853796 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Crash reporter will not compile with latest version of dev-libs/libpcre

Project Member Reported by haddowk@chromium.org, Jun 18 2018

Issue description

Following error was observed:

crash-reporter-0.0.1-r2786: ../../../../../../../tmp/portage/chromeos-base/crash-reporter-0.0.1-r2786/work/crash-reporter-0.0.1/crash-reporter/chrome_collector.cc:173:3: error: unknown type name 'string'; did you mean 'pcrecpp::string'?
crash-reporter-0.0.1-r2786:   string pid_data;
crash-reporter-0.0.1-r2786:   ^~~~~~
crash-reporter-0.0.1-r2786:   pcrecpp::string
crash-reporter-0.0.1-r2786: ../../../../../../../usr/include/pcre_stringpiece.h:59:12: note: 'pcrecpp::string' declared here
crash-reporter-0.0.1-r2786: using std::string;
crash-reporter-0.0.1-r2786:            ^
crash-reporter-0.0.1-r2786: 1 error generated.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/35bde29189f35adae992b859e7269d2899b16b40

commit 35bde29189f35adae992b859e7269d2899b16b40
Author: Keith Haddow <haddowk@chromium.org>
Date: Tue Jun 19 21:38:48 2018

crash: Fix missing qualifier for string class

daisy-release-tryjob
https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Try/b8943364758297146448

eve-release-tryjob
https://ci.chromium.org/p/chromeos/builders/luci.chromeos.general/Try/b8943364748425384688

BUG= chromium:853796 
TEST=tryjobs

Change-Id: Ib15bb24ad123317d376fe05210a8ad3c7fcf91cc
Reviewed-on: https://chromium-review.googlesource.com/1105191
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/35bde29189f35adae992b859e7269d2899b16b40/crash-reporter/chrome_collector.cc

Status: Fixed (was: Started)

Sign in to add a comment