FTR: In issue 872981, we got feedback that the accessory is very unexpected if there is a popup. The intended changes here should resolve that confusion.

(Updated priority and owner to reflect that I am already working on this.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9347775e5a4c4baaa090106a9e67b352bbcc9dd7

commit 9347775e5a4c4baaa090106a9e67b352bbcc9dd7
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Aug 13 15:38:14 2018

[Android] Make autofill keyboard use clank architecture

This CL reworks the way autofill suggestions are communicated to the
keyboard accessory. Instead of setting an additional view, they behave
like all other actions.
The old accessory adjusted its layout based on the website's layout.
This was removed for now - the system-wide setting is used instead.

Side effect: This seems to resolve most known crashes.

Known issues:
- chip elevation has no effect pre-Lollipop (TODO)

Old bugs:
- inconsistent state of scrollview most likely solved
  (--> no scrollview, no inconsistent state)
- flaky tests passed 30/30 locally times but reenabling will happen
  separately (issue 854224, might still flake on bots)

Demo video:
https://drive.google.com/open?id=1aJbjtTZPP-hPZu2FYA_qHRHqaeHkfWCq

Bug: 853772, 834976
Change-Id: I53ed7a18a72e72f72bae45906ac9bb5ee06992e3
Reviewed-on: https://chromium-review.googlesource.com/1170771
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582589}
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/res/drawable/autofill_chip_inset.xml
[delete] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/chrome/android/java/res/layout/autofill_keyboard_accessory_icon.xml
[delete] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/chrome/android/java/res/layout/autofill_keyboard_accessory_item.xml
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/res/layout/keyboard_accessory.xml
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/res/layout/keyboard_accessory_action.xml
[add] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/res/layout/keyboard_accessory_chip.xml
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryBridge.java
[delete] https://crrev.com/5b2ab78928315ecdec95962e6f138bffcdecd868/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillKeyboardSuggestions.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModel.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryBridge.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/java_sources.gni
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillKeyboardAccessoryIntegrationTest.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/chrome/browser/password_manager/password_accessory_metrics_util.h
[modify] https://crrev.com/9347775e5a4c4baaa090106a9e67b352bbcc9dd7/tools/metrics/histograms/enums.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a562f181201b1650f282144256c4894135457be7

commit a562f181201b1650f282144256c4894135457be7
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Nov 19 10:36:02 2018

[Mfill Android] Apply v2 style on keyboard accessory

This CL introduces the new style of the keyboard accessory (clean white)
to highlight is as part of the Chrome UI. It's also the base for IPH
which will explicitly state the origin of suggestions and actions.

Because the new design uses autofill suggestions as integral part, it is
guarded by the #autofill-keyboard-accessory-view flag which isn't used
in other way anymore.

To keep the old implementation until the new design is fully approved
and fleshed out, the KeyboardAccessoryModernView* classes extend the
existing classes and replace them if the appropriate flags are set.

For screenshots highlighting the differences, see:
go/keyboard-accessory-v2

Bug: 853772,  876750 
Change-Id: I44718a4e2269d17b002d7dc890784a847ed840e7
Reviewed-on: https://chromium-review.googlesource.com/c/1338087
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609230}
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/drawable/ic_keyboard.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_modern.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_suggestion.xml
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/res/layout/keyboard_accessory_tabs.xml
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernView.java
[add] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernViewBinder.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryProperties.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/java_sources.gni
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/about_flags.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/chrome/browser/password_manager/password_accessory_metrics_util.h
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_util.cc
[modify] https://crrev.com/a562f181201b1650f282144256c4894135457be7/components/autofill/core/common/autofill_util.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a307892d19c6c84b9df0750f4ae90e279c73835

commit 3a307892d19c6c84b9df0750f4ae90e279c73835
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Dec 03 11:10:51 2018

[Mfill Android] Use AccessorySheetData in UI

This CL moves the transformation of AccessorySheetTab data to
KeyboardAccessoryData.Items from the ManualFillingBridge into the
PasswordsAccessorySheetMediator.
This enables replacing the Items in a follow-up CL completely and use
the AccessorySheetTab to implement the new layout for the passwords.

This is a step towards generalization of accessory sheet tabs as new
tab will be able to add separate element types with respective views.

Bug: 853772
Change-Id: I678d453245568ef006de932274db044b14ffbdfa
Reviewed-on: https://chromium-review.googlesource.com/c/1350890
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613040}
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingBridge.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingIntegrationTest.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingTestHelper.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingUiCaptureTest.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java
[modify] https://crrev.com/3a307892d19c6c84b9df0750f4ae90e279c73835/chrome/browser/android/password_manager/manual_filling_view_android.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb8587a0131ab38c4c17164c60edc2860e5ff063

commit fb8587a0131ab38c4c17164c60edc2860e5ff063
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Dec 06 14:36:16 2018

[Mfill Android] Wrap AccessorySheetTab data by type

This CL adds the new representation for tab data next to the existing
one. This ensures that the old UI still works and the new UI is
completely guarded by #autofill-keyboard-accessory-view.

The actual drawing of the elements follows in crrev.com/c/1356547.

Bug: 853772, 911084
Change-Id: Ia38706aefb687fbe704b62307fa7d793a9b45c36
Reviewed-on: https://chromium-review.googlesource.com/c/1350875
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614338}
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetProperties.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/fb8587a0131ab38c4c17164c60edc2860e5ff063/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f052d6549d7c1fc34811fee5c187555afe429fb

commit 6f052d6549d7c1fc34811fee5c187555afe429fb
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Dec 10 21:22:36 2018

[Mfill Android] Bind wrapped accessory tab data to legacy views

This CL binds the new accessory sheet tab model to the existing views.
This enables two things:
 - Deprecation of the "Item" class
 - Adding a second view binder for modern views crrev/c/1367650

The underlying idea for this change is to keep the consistent model
while allowing different view binders. This allows to change the
appearance of the accessory sheet depending on flags. Details here:
go/keyboard-accessory-v2#heading=h.zhlmmn68rx2p

The user-visible changes? None.
This CL only prepares for modern views (see crrev/c/1367650).
(It used to happen all in this CL, but I decided to split it)

Bug: 853772, 911084
Change-Id: Id1933a66fea7dfc211c747bc5ed1dd749871fdfd
Reviewed-on: https://chromium-review.googlesource.com/c/1356547
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615258}
[add] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/res/layout/keyboard_accessory_sheet_tab_legacy_password_info.xml
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/res/layout/password_accessory_sheet_divider.xml
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/res/layout/password_accessory_sheet_label.xml
[add] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/res/layout/password_accessory_sheet_legacy_option.xml
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/res/layout/password_accessory_sheet_option.xml
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/res/layout/password_accessory_sheet_suggestion.xml
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/res/layout/password_accessory_sheet_top_divider.xml
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/res/values/dimens.xml
[add] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabCoordinator.java
[add] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabModel.java
[add] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetMediator.java
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetProperties.java
[delete] https://crrev.com/43b260ae281011748f1eba6185abfe7b0d3d304c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetView.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/java_sources.gni
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewTest.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryIntegrationTest.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewTest.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java
[modify] https://crrev.com/6f052d6549d7c1fc34811fee5c187555afe429fb/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetControllerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c347034892107011aaed034345ef85148afc7cd0

commit c347034892107011aaed034345ef85148afc7cd0
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Dec 20 10:25:16 2018

[Mfill Android] Move keyboard accessory tab layout into own component

In order to cleanly maintain a stable OnPageChangeListener when the
tab switcher may temporarily be destroyed, move it into an separate
component.
This case will happen soon when the tab layout becomes a scrollable
element in the accessory's RecyclerView. Then, there is no guarantee
that the View remains stable. In the mean-time, this also allows to
bind multiple TabLayouts to the same component which might be necessary
to keep a stable V1 implementation.

There should be no user-visible changes to the accessory if
#autofill-keyboard-accessory-view is Disabled (default).

Bug: 853772, 911084
Change-Id: I925691558641e5389dd975f0dd1684b03477225d
Reviewed-on: https://chromium-review.googlesource.com/c/1367732
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618159}
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/res/layout/keyboard_accessory.xml
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/res/layout/keyboard_accessory_modern.xml
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/res/layout/keyboard_accessory_tabs.xml
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetCoordinator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetMediator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetProperties.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryCoordinator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMediator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryMetricsRecorder.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryModernViewBinder.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryProperties.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutCoordinator.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutMediator.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutProperties.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutView.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutViewBinder.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingCoordinator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingMediator.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/java_sources.gni
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutViewTest.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewTest.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryControllerTest.java
[add] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryTabLayoutControllerTest.java
[modify] https://crrev.com/c347034892107011aaed034345ef85148afc7cd0/chrome/android/junit/src/org/chromium/chrome/browser/autofill/keyboard_accessory/ManualFillingControllerTest.java

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9adcf51135695b50847b8004c8d98d08c0bf4a22

commit 9adcf51135695b50847b8004c8d98d08c0bf4a22
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Jan 04 15:53:06 2019

[MFill Android] Create view binder for modern accessory sheet

This CL adds and connects the new view binder which creates chips and
footer commands based on the AccessorySheetTab data.

In order to make the "ripple effect" work for chips, the drawable draws
a large rounded rectangle in the background color over the animated
image which effectively cuts and rounds the corners.

Bug: 853772, 911084
Change-Id: If2740994aa752e11233c90eca062b529b8ea36ce
Reviewed-on: https://chromium-review.googlesource.com/c/1367650
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619959}
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/res/layout/keyboard_accessory_sheet_tab_password_info.xml
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/res/layout/keyboard_accessory_sheet_tab_title.xml
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/res/layout/password_accessory_sheet_option.xml
[modify] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewBinder.java
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessoryInfoView.java
[modify] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetModernViewBinder.java
[modify] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/java_sources.gni
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetTabViewTest.java
[add] https://crrev.com/9adcf51135695b50847b8004c8d98d08c0bf4a22/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetModernViewTest.java